fix(solid): cap solid-js peer range at ^1 by ryansolid · Pull Request #245 · TanStack/charts

ryansolid · 2026-10-28T17:42:01Z

🎯 Changes

The Solid packages here declare an open-ended solid-js peer (>=1.x). Solid 2.0.0 is due shortly. Once it's tagged latest, that range will accept it, so npm install will pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removes solid-js/store, createComputed, mergeProps/splitProps, onMount, batch and more.

This PR changes each range from >=X to ^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way @tanstack/solid-router 2.x and @tanstack/solid-query 6.x did it.

Prereleases (2.0.0-rc.*) never matched >=1.x, which is why nobody has run into this yet.

✅ Checklist

Only peerDependencies ranges and a changeset change; no code changes.

Summary by CodeRabbit

Chores
- Restricted the supported SolidJS peer dependency range to compatible 1.x versions for the charts packages.

The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2

changeset-bot · 2026-10-28T17:42:08Z

🦋 Changeset detected

Latest commit: 9e28cbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@tanstack/charts	Patch
@tanstack/solid-charts	Patch
@tanstack/alpine-charts	Patch
@tanstack/angular-charts	Patch
@tanstack/lit-charts	Patch
@tanstack/octane-charts	Patch
@tanstack/preact-charts	Patch
@tanstack/react-charts	Patch
@tanstack/react-native-charts	Patch
@tanstack/svelte-charts	Patch
@tanstack/vue-charts	Patch
@tanstack/charts-scales	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-10-28T17:42:19Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: b66311a5-e316-490f-b4a3-84c03f1f3f36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c3f3206d-191b-44ea-b214-c4455060569e

Commits

Reviewing files that changed from the base of the PR and between 778f2cc and f9c6c65.

Files selected for processing: 3

.changeset/solid-js-peer-cap.md
packages/charts-core/package.json
packages/solid-charts/package.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Both chart packages change the solid-js peer dependency range from >=1.8 to ^1.8. A patch changeset records the updates for both packages.

Changes: SolidJS peer range

Layer / File(s)	Summary
Update peer dependency range `packages/charts-core/package.json`, `packages/solid-charts/package.json`, `.changeset/solid-js-peer-cap.md`	Both package manifests change the `solid-js` peer dependency range to `^1.8`. The changeset records patch releases for both packages.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: Minimal · previous review f9c6c

No actionable merge-blocking risk remains in this dependency-range update.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: limiting the solid-js peer dependency range to the ^1 major version.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

tannerlinsley · 2026-10-28T17:46:16Z

Thanks Ryan, this catches an important compatibility gap. The lockfile needs the matching change before this can land.

AI review notes:
At f9c6c65, packages/charts-core/package.json declares ^1.8, but its importer in pnpm-lock.yaml still records >=1.8.
An isolated metadata-only check using the exact root/core manifests and lockfile reproduced ERR_PNPM_OUTDATED_LOCKFILE, specifically naming that Solid specifier mismatch. This was not a full checkout test.
Update the core importer specifier to ^1.8, keeping the resolved version unchanged. The Solid adapter importer already uses its unchanged development dependency range, ^1.9.13.
Semver checks confirm the new peer range preserves stable Solid 1 versions from 1.8.0 and excludes stable Solid 2. Both required workflows are currently waiting for approval.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ryansolid · 2026-10-28T18:41:26Z

Thanks Tanner. Updated the lockfile specifier for solid-js in the charts-core importer to ^1.8; the resolved version is unchanged, and pnpm install --frozen-lockfile passes. The same lockfile fix went into form (TanStack/form#2456), pacer (TanStack/pacer#306) and devtools (TanStack/devtools#557).

tannerlinsley · 2026-10-28T18:44:45Z

Thanks Ryan, the lockfile correction checks out. The updated file matches the locally verified correction. This is now waiting on approval for the Conformance and Benchmarks workflows.

chore: update lockfile for solid-js peer cap

9e28cbd

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Navigation Menu

Repository navigation

fix(solid): cap solid-js peer range at ^1 - #245

fix(solid): cap solid-js peer range at ^1#245
ryansolid wants to merge 2 commits into
TanStack:mainfrom
ryansolid:solid-js-peer-cap

ryansolid commented Oct 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 28, 2026 •

edited

Loading

Review skipped

Uh oh!

tannerlinsley commented Oct 28, 2026

Uh oh!

ryansolid commented Oct 28, 2026

Uh oh!

tannerlinsley commented Oct 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ryansolid commented Oct 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

tannerlinsley commented Oct 28, 2026

Uh oh!

ryansolid commented Oct 28, 2026

Uh oh!

tannerlinsley commented Oct 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ryansolid commented Oct 28, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 28, 2026 •

edited

Loading

coderabbitai Bot commented Oct 28, 2026 •

edited

Loading