Slightly adapt unit test to test additional scenario.#601
Merged
Conversation
This new unit test would have failed in version 1.2.4, but is fixed in version 1.3.0. The problem is an ASK graph pattern with two variables, while the ANSWER graph pattern has one of these variables filled in with a concrete value. This concrete value would not end up in the result, which is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new unit test would have failed in version 1.2.4, but is fixed in version 1.3.0. The problem is an ASK graph pattern with two variables, while the ANSWER graph pattern has one of these variables filled in with a concrete value. This concrete value would not end up in the result, which is wrong.