Code review

[rcsmit]

FYI: code review op https://www.youtube.com/watch?v=qeZ2tPgdess

[JackJackie]

Thx Rene for your attention! We'll review the review and see what we can improve!

[rcsmit]

Hi, it's not me who did the video :) All the best :)

[bnouwt]

Some suggested improvements mentioned in above video:

• - move certain dependencies (such as logging) to dependencies management section of parent module.
• - add architectural figure with dependencies between components.
• - extend description of different Maven modules.
• - add static analysis reporting tool to CI/CD
• - mention code convention in /ide folder in developer info.

[bnouwt]

Moved the following dependencies to the dependency management section of the parent pom:

• slf4j-simple dependency
• junit dependencies
• jetty, jersey3, jackson dependencies

Added code convention and missing components to README.md and refer to the high-level design of the smart connector.

Ran one-time static analysis reporting tool locally following (partly) this guide. And also using the Eclipse SonarQube plugin. The results were quite good, although of course a lot of improvements can still be done. Noticed there is a strong push by SonarQube to move to their server-based solution and I am not sure I like that. Doing static code analysis more consistently during CI/CD is part of issue #361.