Fixing now() integer issue to return proper Unix epoch in milliseconds.#74
Merged
iObject merged 2 commits intoTKSS-Software:masterfrom Apr 7, 2026
Merged
Conversation
TwitchBronBron
approved these changes
Mar 30, 2026
Collaborator
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks good to me. @iObject ?
iObject
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all!
While using rodash
now()method I noticed some inconsistencies when comparing to true epoch time in milliseconds.dateObj.AsSeconds()was not converted to milliseconds before the addition ofdateObj.GetMilliseconds()Integeris not adequate for use as it is only capable of handling integers that are 11 digits long, whereas a true millisecond timestamp requires 13 digits.I changed the function to reflect the changes needed as well as the unit test that tests it, although I am not sure if I did that correctly.
Please let me know if I made a mistake anywhere or if you'd like me to change anything.
Thanks!
P.S. Type declaration with
&is necessary to coercedateObj.asSeconds()toLonginteger, otherwise it's anIntegerand we're back to the same problem.