Repository navigation
Fix std::string to const char* compilation error on arduino-esp32 v3.x - #86
Open
Tejakshaya wants to merge 1 commit into
Open
Tejakshaya wants to merge 1 commit into
Tejakshaya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compilation failure on arduino-esp32 v3.x (ESP32 Arduino Core 3.0+) where
BLEDevice::init()andBLECharacteristic::setValue()now expectconst char*instead ofstd::string.Changes:
.c_str()toBLEDevice::init()call at line 143.c_str()tohid->manufacturer()->setValue()call at line 151Why
Starting with arduino-esp32 v3.0, the BLE API changed its function signatures from accepting
std::stringtoconst char*and this causes the library to fail to compile with errors like:error: cannot convert 'std::string' to 'const char*'
The fix is backward-compatible —
.c_str()works on all versions.Closes #73
Closes #84