Repository navigation
mw-plugin-test: --allow known-debt ratchet for the plugins gate - #723
Merged
Merged
Conversation
…check.allow The plugins gate ran for the first time on 2026-07-30 (it had died in checkout since being armed) and truthfully reported the repo's pre-existing debt: 12 packages failing the install-idempotence pin (plugins#235) and six Tests areas that shipped red while nothing executed them. Without a ratchet the gate can only merge red or be silenced. --allow <file> names the known debt per scope+check (install/idempotence on packages, compile/render/tests on types): listed failures are tolerated and labeled, new failures fail, and an entry whose check passes again is STALE and fails until removed — the list only shrinks. A skipped check or absent scope is unverifiable and warned, never failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013H31ey1UdhPk4xXdhVQBw7
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “known-debt allowlist” ratchet to mw-plugin-test so the MeshWeaver.Plugins gate can be enforced without permanently staying red: listed failures are tolerated as debt, new failures fail the run, and stale allowlist entries (now passing) fail until removed.
Changes:
- Add
--allow <file>CLI option and compute aGateVerdictthat classifies failures into new vs known debt, plus stale/unverifiable allow entries. - Extend
GateReport.WriteSummary(...)to reflect the allowlist verdict (DEBT labeling, stale/unverifiable reporting, and a verdict-driven final line). - Introduce
GateAllowlistparsing and the verdict evaluation logic.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/MeshWeaver.PluginTester/Program.cs | Adds --allow argument parsing and applies the allowlist verdict to determine exit code and summary output. |
| tools/MeshWeaver.PluginTester/GateReport.cs | Updates summary writer to support allowlist-aware labeling and final verdict output. |
| tools/MeshWeaver.PluginTester/GateAllowlist.cs | New allowlist format/parser and verdict evaluation (new failures vs debt, stale/unverifiable entries). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+38
| case "--allow" when i + 1 < args.Length: | ||
| allowlist = GateAllowlist.Load(args[++i]); | ||
| allowApplied = true; | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
Fixed in 317bd42: a value-taking option as the last argument now errors with "requires a value" (exit 2) — applied to --compile-timeout/--render-timeout too, which had the same fall-through.
Comment on lines
+28
to
+33
| /// <summary>Parses the allow file, throwing on a malformed line — a typo that silently | ||
| /// allowed nothing (or everything) would defeat the ratchet.</summary> | ||
| public static GateAllowlist Parse(IEnumerable<string> lines) | ||
| { | ||
| var entries = new List<AllowEntry>(); | ||
| var number = 0; |
Contributor
Author
There was a problem hiding this comment.
Added GateAllowlistTest (15 cases) in 317bd42: parse incl. malformed-line throw, known/new split, the stale rule (exact scope only), the unverifiable escape (absent scope, skipped tests, idempotence behind a failed install), and the single-verdict summary.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
…ned by tests --allow (and the timeout flags) as the last argument now say 'requires a value' instead of the misleading 'Unknown argument'. GateAllowlistTest pins parse (comments, case, malformed-line throw), the known/new split, the stale rule (a passing entry fails until removed, exact scope only), the unverifiable escape (absent scope, skipped tests, idempotence behind a failed install), and the one-verdict summary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013H31ey1UdhPk4xXdhVQBw7
This was referenced Aug 27, 2026
Module-bundle lane publishes only on pushes — a release-follow schedule rebuild is thrown away
#2088
Closed
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MeshWeaver.Plugins
test-reposgate executed for the first time today (Systemorph/MeshWeaver.Plugins#250 fixed its run mechanics — it had died inactions/checkoutsince being armed) and truthfully reported pre-existing debt: 12 packages failing the install-idempotence pin (tracked in MeshWeaver.Plugins#235), six Tests areas red on main (never executed in CI before), and one in-mesh compile failure. A gate that can only merge red or be silenced gets turned off; this adds the same one-way ratchet the plugins repo already uses forcompile-check.allow:--allow <file>: lines of<scope> <check>(install/idempotenceon package ids,compile/render/testson NodeType paths),#comments.[known-debt](package rolls up asDEBT); a new failure fails the run.STALEand fails the run until removed — the list only shrinks.Without
--allowbehavior is byte-for-byte unchanged. Consumer change (workflow flag + the populatedplugin-gate.allow): MeshWeaver.Plugins#250.🤖 Generated with Claude Code
https://claude.ai/code/session_013H31ey1UdhPk4xXdhVQBw7