Skip to content

ci(review-answered): re-run a red gate when any internal review completes, not only the degradation - #6020

Merged
meshweaver-cloud[bot] merged 1 commit into
mainfrom
fix/review-answered-rerun-on-late-review
Oct 3, 2026
Merged

meshweaver-cloud[bot] merged 1 commit into
mainfrom
fix/review-answered-rerun-on-late-review

Conversation

@rbuergi

@rbuergi rbuergi commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Why

On 2026-10-03 the control instance queued the internal reviewer's rounds behind its capacity bound for more than 75 minutes. Core #6014, #6017 and #6018 were reviewed after Automatic review answered had finished its 15-minute wait and published red. The review's arrival then re-ran nothing that branch protection reads, so core merged nothing until someone pushed.

review-answered-on-degradation.yml already does the right thing: it re-runs the newest pull_request run of the gate for the head. Until now it did that only for the "Reviewer unavailable" degradation.

What

  • The listener now fires on any completed internal-review check run from the internal reviewer's App (systemorph-com, 4918443), whatever its conclusion. It still lets gate runs that are in flight finish, and leaves a gate that already reads success alone. The re-run judges the head itself, so this changes no verdict.
  • Job and step names now say what the listener does. They are not required contexts, and nothing references them.
  • Doc/Architecture/ReviewFindingsAnswered records the change and the incident.

The companion admission fix (reviews unlimited while the model pool has headroom) is Systemorph/MeshWeaver.Plugins#2746.

🤖 Generated with Claude Code

…etes, not only the degradation

Core #6014/#6017/#6018 (2026-10-03) were reviewed after the gate's 15-minute
wait had already published red; the review's arrival re-ran nothing branch
protection reads, and core sat idle. The listener now re-runs the newest
pull_request gate run on any completed internal-review check run of the
internal reviewer's App; the gate still judges the head itself.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@meshweaver-cloud
meshweaver-cloud Bot enabled auto-merge October 3, 2026 13:31
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 0)

  1 files    1 suites   2m 18s ⏱️
348 tests 348 ✅ 0 💤 0 ❌
352 runs  352 ✅ 0 💤 0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 4)

839 tests   646 ✅  2m 29s ⏱️
  4 suites  193 💤
  4 files      0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 2)

    4 files      4 suites   3m 53s ⏱️
1 264 tests 1 264 ✅ 0 💤 0 ❌
1 265 runs  1 265 ✅ 0 💤 0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 1)

    3 files      3 suites   5m 17s ⏱️
2 297 tests 2 297 ✅ 0 💤 0 ❌
2 300 runs  2 300 ✅ 0 💤 0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 3)

    4 files      4 suites   12m 19s ⏱️
2 991 tests 2 991 ✅ 0 💤 0 ❌
2 993 runs  2 993 ✅ 0 💤 0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 5)

    4 files      4 suites   12m 52s ⏱️
2 725 tests 2 725 ✅ 0 💤 0 ❌
2 728 runs  2 728 ✅ 0 💤 0 ❌

Results for commit 6e8e7ae.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

    20 files      20 suites   39m 10s ⏱️
10 464 tests 10 271 ✅ 193 💤 0 ❌
10 477 runs  10 284 ✅ 193 💤 0 ❌

Results for commit 6e8e7ae.

@meshweaver-cloud
meshweaver-cloud Bot merged commit 703e9c6 into main Oct 3, 2026
@rbuergi
rbuergi deleted the fix/review-answered-rerun-on-late-review branch October 10, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant