feat(settings): Inbox, Invitations and token rows get their own buttons back — row-scoped actions (B3) by rbuergi · Pull Request #5967 · Systemorph/MeshWeaver

rbuergi · 2026-10-01T18:12:42Z

Row-scoped actions for the B3 settings tabs (#5955): the per-row buttons that data-binding B3 part 2 (#5947) had to downgrade to "select the row, then press the button below the grid" are back — Archive on each Inbox mail, Revoke on each invitation, Rotate and Revoke on each service-identity token.

Stacked: base is feat/databinding-b3-settings (#5947 → #5944), and the branch carries #5955's commit cherry-picked so it builds. Draft until #5955 and the B3 chain land on main; then rebase onto main (the cherry-picked commit drops out as already applied). Sibling of #5956 (the coupon list, on #5948); both edit the same DataBinding.md bullet, so whichever lands second resolves that one paragraph.

What changed

InboxSettingsTab.MailGrid, InvitationsSettingsTab.InvitationGrid, ServiceIdentitiesSettingsTab.TokenGrid (the template half, split from the feeds and taking the action, so the row routing is testable): each action is ONE button in a TemplateColumnControl, and its click reads the row with ctx.RowAs<TRow>() — the row as the person saw it, never re-read by position. A click with no row does nothing.
Gone: the three selection /data slots, the bound selection labels, the grid-level DataGridCellClick handlers, the Display / None row members, and the "select a row first" hints.
An action that applies only to some rows (an archived mail, an accepted or revoked invitation, a revoked token) refuses on the result line and says why — three new keys (inbox.alreadyArchived, invitations.notPending, serviceIdentities.tokenRevoked, en + de) replace the three hint keys, which feat(settings): seven settings tabs are templates — fed grids and markdown (data-binding B3, part 2) #5947 added and nothing else uses.
#5948 (coupon / registration-key / instance-grant lists) checked: its only downgraded per-row action is the coupon Open button, which feat(plugincatalog): the coupon list's per-row Open button is back — a row-scoped action (reference conversion) #5956 restores; the registration-key and instance-grant revoke buttons are forms keyed by id and were not downgraded.
DataBinding.md: the per-row-action bullet describes the row-scoped shape with these tabs as its examples; the "platform gap" sentence says the gap is closed.

Evidence

test/Memex.Portal.Shared.Test/SettingsRowActionsActOnTheClickedRowTest (12/12, a theory over the four buttons): row k's button acts on row k for every k; the list changes between render and click (rows inserted above, the clicked one gone) and the click still acts on the clicked row; negative control — the same click with no row runs nothing.
Also green: LocalizationTest (66/66), LayoutAreaDataBakeRatchetGuard + DocumentationLinkIntegrityTest (4/4). None of the three tabs is in LayoutAreaDataBakeSites.allow, so the budget is unchanged.
Release -warnaserror clean (0 warnings, 0 errors): Memex.Portal.Shared, Memex.Portal.Shared.Test, MeshWeaver.Documentation.Test, MeshWeaver.Messaging.Hub.Test.
NOT established: a click in a browser on a running portal.

Deploy

Compiled portal code; no node recycle beyond the roll. The Blazor half (Systemorph/MeshWeaver.Plugins#2656) must be live for the browser to send the row; until then a click acts on nothing (the negative-control behaviour), which is why this lands after both.

Pairs-with: none — no public type or member removed (the changed members are internal).
Implementers: none — no interface member added.
Mirror-sync: tracked with #5947's own catalog sync — this replaces three keys #5947 adds (never on main) with three new ones; after the chain merges, npm run sync:i18n -- --ref <merged core sha> in MeshWeaver.Plugins picks up both.

🤖 Generated with Claude Code

…e carries its row A bound row template (BindMany / ItemTemplateControl, a DataGrid TemplateColumnControl) exists ONCE on the owner, so a button in it posted a ClickedEvent naming only the template's area and its action could not tell which row was clicked. The data-binding batches had to downgrade per-row buttons to "click the row, then act" or leave areas unconverted. - RowContext (Pointer, Index, Value, Path; NodePath()) — the row AS THE CLIENT RENDERED IT. - ClickedEvent.Row / BlurEvent.Row (init, non-breaking); the owner hands it to the action as UiActionContext.Row. Never re-resolved by index: a list that changed between render and click still acts on the clicked row. - ctx.RowAs<T>() (Mesh.Contract, via ObjectAsExtensions.As) and ctx.RowPath(). - DataGridControl renders each template column's template into {grid}/Column{i}, so a cell's control and its click action are found where the client's event names them (before, the template lived only inline and a click reached the GRID's area). - RowContext registered with the layout types. Tests: RowScopedClickActionTest — N rows, row k acts on row k; a no-row negative control; the list changing between render and click; a grid template column (red without the RenderSelf change). Doc: GUI/DataBinding → "Row-scoped actions". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…eir per-row buttons back — row-scoped actions B3 part 2 made these three admin lists fed grids but had to downgrade each per-row action to "select the row, then press the button below the grid" (a button in a bound row could not say which row it was). With row-scoped actions (#5955) each row carries its own button again: - Inbox: Archive per mail (InboxSettingsTab.MailGrid). - Invitations: Revoke per invitation (InvitationsSettingsTab.InvitationGrid). - Service identities: Rotate and Revoke per token (ServiceIdentitiesSettingsTab.TokenGrid). Each button lives in a TemplateColumnControl, is declared once, and its action reads the row from the click (ctx.RowAs<TRow>()) — the row as the person saw it, never re-read by position. The grid function takes the feed and the action, so the row routing is testable. The selection slots, the bound selection labels and the "select a row first" hints are gone; an action that applies only to some rows refuses on the result line and says why (three new en+de keys replace the three hints). SettingsRowActionsActOnTheClickedRowTest (12): for each of the four buttons, row k acts on row k for every k; a list change between render and click still acts on the clicked row; a click with no row does nothing (negative control). DataBinding.md: the per-row bullet now describes the row-scoped shape with these tabs as its examples. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

github-actions · 2026-10-01T18:18:17Z