Repository navigation
ci(allow): drop the stale Rail record-signature allow entry (#3414 has merged) — unblocks the queue - #3421
Merged
Conversation
…as merged The entry said 'DELETE THIS LINE in the change right after #3414 merges'. #3414 merged at 13:38Z and the line stayed, so `Public surface (binary compatibility)` reds on every PR and every merge-queue build that touches C# (#3415, #3418, #3420) with '0 binary-breaking record change(s), 1 stale allow entr(ies)' while main itself reads green — its own gate was reuse-skipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a single-line allowlist cleanup and the allow-file reader correctly handles an empty entries list.
Pull request overview
Removes a now-stale Rail entry from the binary-compatibility record-signature allowlist so the check-record-signatures.py gate stops failing after #3414’s merge.
Changes:
- Deleted the
Railallow entry fromscripts/record-signatures.allow(file is back to header-only / no entries).
File summaries
| File | Description |
|---|---|
| scripts/record-signatures.allow | Drops the stale Rail allowlist line to unblock the record-signature compatibility gate and merge queue. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The queue is red on a stale allow entry
scripts/record-signatures.allowcarries theRailline from #3406, whose own text says DELETE THIS LINE in the change right after #3414 merges. #3414 merged at 13:38Z and the line stayed, soPublic surface (binary compatibility)now reds on every PR and merge-queue build that touches C# — #3415 (queue run 34037425197), #3418 (34037343949), #3420 — with:while main itself reads green because its gate was reuse-skipped on 7812631. Same shape as the recorded
type-forwards.allowtrap: an allow entry goes stale the moment its PR merges.One line removed; the file is empty of entries again.
check-record-signatures.py --self-testunchanged.Pairs-with: none — a CI allow file.
🤖 Generated with Claude Code