fix(mesh): the router names a spokesman — no one publishes from the main hub, and gone-subscriber stream-end drops go quiet by rbuergi · Pull Request #2928 · Systemorph/MeshWeaver

rbuergi · 2026-08-31T23:36:59Z

Kills two measured log floods at the root ('no one must ever publish from main hub'):

Recycle announcements no longer carry the router's identity: MeshBuilder registers a RouterCarrier spokesman (the nodeops execution hub — the seam all node CRUD already uses); Workspace resolves it when its parent is router-typed. RecycleStrandsLiveSubscriberTest (the production strand repro) passes in 587ms — a naive climb-past-the-router instead hung it a full minute, which is why the spokesman exists.
StreamEndedEvent to an already-departed subscriber drops at Debug — a typed no-op ('nothing more comes' to someone who already left); every other StreamMessage drop stays WARN because those are real signal.

🤖 Generated with Claude Code

…okesman, and a terminal notice to a departed subscriber is Debug 'No one must ever publish from main hub' + the log flood ('we get tons of this … get rid of all of this'), maintainer, 2026-09-01. Two roots, measured on the compile+render gate and the live portal: 1. Workspace's recycle announcement posted StreamEndedEvent through Configuration.ParentHub — for a per-node/activity hub that IS the mesh router, so every recycled activity produced a ROUTER_TRAFFIC violation ('StreamEndedEvent has the mesh hub as sender'). The router now registers a RouterCarrier spokesman (MeshBuilder → the nodeops execution hub, the same seam every node-CRUD path already hops onto); Workspace resolves it when the parent is router-typed, falls back to the router's own non-router parent, and with neither present keeps the documented change-feed-latch recovery. RecycleStrandsLiveSubscriberTest (the production strand repro) passes in 587ms — the announcement still lands, without the router's identity. (A naive climb-past-the-router hung it for a full minute: in the Monolith host the router is the only parent, which is exactly why the spokesman exists.) 2. A StreamEndedEvent dropped because the target stream is ALREADY GONE is a typed no-op — its entire meaning is 'nothing more comes', which a departed subscriber knows by definition — yet it logged one WARN per released reader (Information+ ships to Loki). The drop is Debug for that one type; every other StreamMessage drop (a lost Full renders a region blank) stays a warning. Level change justified by type semantics, not convenience. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Copilot

Pull request overview

This PR reduces ROUTER_TRAFFIC-related log floods by ensuring recycle announcements don’t originate from the mesh router hub and by downgrading benign StreamEndedEvent drops to Debug.

Changes:

Introduces a RouterCarrier “spokesman” abstraction and registers it in MeshBuilder to route router-adjacent infrastructure posts through the nodeops execution hub.
Updates Workspace recycle announcements to avoid router-stamped senders by resolving a non-router carrier (via RouterCarrier or a non-router parent).
Changes DataExtensions logging so StreamEndedEvent drops for already-gone subscribers log at Debug, while other dropped stream messages remain Warning.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/MeshWeaver.Messaging.Hub/RouterCarrier.cs	Adds a router “spokesman” record used to select a non-router hub for infrastructure posting.
src/MeshWeaver.Mesh.Contract/MeshBuilder.cs	Registers a default `RouterCarrier` mapping the router to `NodeOperationExecutionHub()`.
src/MeshWeaver.Data/Workspace.cs	Uses `RouterCarrier` (or a safe parent fallback) to avoid router-stamped recycle announcements.
src/MeshWeaver.Data/DataExtensions.cs	Lowers log level for benign `StreamEndedEvent` drops while keeping other drop diagnostics at Warning.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+            IMessageHub? spokesman = null;
+            try { spokesman = carrier.Configuration.Get<RouterCarrier>()?.Resolve(carrier); }
+            catch { /* teardown probing must never throw */ }
+            if (spokesman is null)
+            {
+                IMessageHub? up;
+                try { up = carrier.Configuration.ParentHub; }
+                catch { up = null; }
+                spokesman = up is null || ReferenceEquals(up, carrier)
+                            || string.Equals(up.Address.Type, AddressExtensions.MeshType, StringComparison.Ordinal)
+                    ? null : up;
+            }


github-actions · 2026-08-31T23:44:21Z