Repository navigation
ci(cd): a bake-only reconcile recovers the release version from the promoted image - #2496
Merged
Merged
Conversation
…romoted image The first scheduled reconcile that ever fired (run 33063843072, once #2491 gave the cron its own concurrency lane) published the platform bake correctly — sealed on all three targets — and then died in "Assert the armed release is one an environment can be rolled to" on `${1:?usage}`: RELEASE_VERSION came from `needs.portal-image.outputs.version`, and on a bake-only run that job is skipped, so the string was empty. Quietly, the publish step before it had written no release marker either, so the one thing a reconcile exists to heal — "release X may be rolled to" — was the one thing it could not do. The version (3.0.0-rc8.ci.<run#>) is per-run and not recomputable, but it is recorded: promote's Phase C tags memex-portal-ai:<version> on the same digest Phase A tagged <short-sha> — the tags SelfUpdateHostedService rolls from. publish-bake now resolves the version once, in a `release` step (this run's output, else the promoted image's tag set via `az acr manifest list-metadata`), and both the publish and the assert read that step. A sha with no version tag was never armed; the step exits 1 instead of publishing a marker for an invented version or falling back to identity-only. Pinned by PlatformBakeLaneGuard.PlatformBake_ResolvesTheReleaseVersionOnce_AndEveryConsumerReadsIt, which caught a self-reference in the first draft of this very change. CiContentBake.md gains the section. Refs #2491. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rbuergi
enabled auto-merge
August 27, 2026 10:53
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the platform CD reconcile path so a bake-only run can still determine the release version it is healing, by recovering the version tag from the already-promoted portal image when portal-image is skipped.
Changes:
- Add a
releasestep topublish-bakethat resolvesRELEASE_VERSIONeither from this run (portal-image) or from the promotedmemex-portal-aiimage tags (bake-only reconcile). - Update bake publishing and release-availability assertion to consume
steps.release.outputs.versioninstead ofneeds.portal-image.outputs.version. - Add/extend structural guard test coverage and documentation to pin the intended workflow invariants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/main-cd.yml |
Introduces a release step to resolve the release version for bake-only reconciles and rewires downstream consumers to use it. |
test/MeshWeaver.Documentation.Test/PlatformBakeLaneGuard.cs |
Adds a guard test that enforces “resolve version once” and ensures all consumers read the resolved output. |
src/MeshWeaver.Documentation/Data/Architecture/CiContentBake.md |
Documents why bake-only reconcile must recover the release version and how the workflow does it. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1503
to
+1505
| tags=$(az acr manifest list-metadata --registry meshweaver --name memex-portal-ai \ | ||
| --query "[?contains(tags, '${SHORT_SHA}')].tags[]" -o tsv 2>/dev/null || true) | ||
| version=$(grep -E '^[0-9]+\.[0-9]+\.[0-9]+' <<<"$tags" | grep -vx "$SHORT_SHA" | head -1 || true) |
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first scheduled reconcile that ever fired (run 33063843072, once #2491 gave the cron its
own concurrency lane) published the platform bake correctly — sealed on all three targets —
and then died in "Assert the armed release is one an environment can be rolled to" on
${1:?usage}: RELEASE_VERSION came fromneeds.portal-image.outputs.version, and on abake-only run that job is skipped, so the string was empty. Quietly, the publish step before
it had written no release marker either, so the one thing a reconcile exists to heal —
"release X may be rolled to" — was the one thing it could not do.
The version (3.0.0-rc8.ci.<run#>) is per-run and not recomputable, but it is recorded:
promote's Phase C tags memex-portal-ai: on the same digest Phase A tagged
— the tags SelfUpdateHostedService rolls from. publish-bake now resolves the version once, in
a
releasestep (this run's output, else the promoted image's tag set viaaz acr manifest list-metadata), and both the publish and the assert read that step. A shawith no version tag was never armed; the step exits 1 instead of publishing a marker for an
invented version or falling back to identity-only.
Pinned by PlatformBakeLaneGuard.PlatformBake_ResolvesTheReleaseVersionOnce_AndEveryConsumerReadsIt,
which caught a self-reference in the first draft of this very change. CiContentBake.md gains
the section. Refs #2491.
🤖 Generated with Claude Code