Repository navigation
Remove every client-i reference from the repo - #2312
Merged
Merged
Conversation
atioz is a customer-identifying name in a PUBLIC repository, and the environment itself is retired: every deployment in the namespace is scaled to 0/0 and it serves nobody. All 32 references are gone. Most were incident evidence in comments — "Prod (atioz, 2026-08-07)", "THE atioz DEFECT" — so the edits drop the NAME and keep the finding, because the evidence is why the code looks the way it does: Prod (atioz, 2026-08-07) had one RouteMessage turn -> Prod (2026-08-07) had one RouteMessage turn Found live on <c>atioz</c> 2026-08-10, whose 8 -> Found live in production 2026-08-10, on an THE atioz DEFECT (2026-08-10) -> THE PRODUCTION DEFECT (2026-08-10) Environment lists lose the entry (`memex/atioz/memex-cloud` -> `memex/memex-cloud`), and three measurement tables lose their atioz row. Where a table's prose counted the rows, the prose is corrected too — CHANGE-PROPAGATION.md said "all three portals" and now says "the portals", so the sentence still matches the table under it. Nothing functional changes: this repo never held atioz deployment config. Every helm edit is inside a `#` comment, so no YAML structure moved. Companion change, in Systemorph/Memex (9994d81): atioz is removed from deployments/aks/envs.json, the Chart Drift environment matrix. Chart Drift starts working today (#1709) and a retired environment left in the matrix would report drift on every daily run forever — a gate whose red is permanent is a gate people learn to ignore. The namespace, its PVCs, its database and deployments/aks/atioz/ are all retained deliberately and are NOT touched. Verified: all 7 touched projects build clean with `-c Release -warnaserror`; DocumentationLinkIntegrityTest passes (fresh trx). Category: none — comments, docs and skills only, no user-visible effect.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the customer-identifying environment name atioz from this public repository while preserving the underlying incident/behavior evidence by rewriting affected comments and documentation to use non-identifying “production” phrasing and by removing the retired environment from environment lists/tables.
Changes:
- Rewrites incident-evidence comments in source and tests to remove the
atiozidentifier while keeping dates/technical details intact. - Updates documentation and Helm chart commentary tables/lists to remove the retired environment entry and any prose that depended on the removed row.
- Updates internal agent/skill docs and workflow comments that referenced
atiozas part of environment matrices/examples.
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/MeshWeaver.PluginCatalog.Test/PluginDependencyOrderTest.cs | Removes atioz identifier from defect evidence comment. |
| test/MeshWeaver.PluginCatalog.Test/DeclaredAccessInstallTest.cs | Rewords production incident evidence to remove atioz. |
| test/MeshWeaver.Hosting.Orleans.Test/RoutingGrainTurnIsolationTest.cs | Removes atioz from production evidence comment while keeping technical detail/date. |
| test/MeshWeaver.Hosting.Monolith.Test/SelfUpdatePollerResilienceTest.cs | Rewords outage evidence/comments to remove environment identifier. |
| test/MeshWeaver.Graph.Test/CompileFailureReportedOnceTest.cs | Replaces portal list including atioz with generic “production portals”. |
| src/MeshWeaver.PluginCatalog/PackageInstaller.cs | Rewords historical evidence comment to remove atioz identifier. |
| src/MeshWeaver.PluginCatalog/InstanceAutoRegistrationService.cs | Rewords incident evidence comment to remove atioz. |
| src/MeshWeaver.Mesh.Contract/Threading/IoPoolOptions.cs | Removes atioz from production evidence comment in IoPool naming docs. |
| src/MeshWeaver.Hosting/DynamicTypePreWarmerHostedService.cs | Rewords portal measurement comment to avoid the environment name. |
| src/MeshWeaver.Hosting.Orleans/RoutingGrain.cs | Removes atioz from production evidence comment while retaining diagnostic details. |
| src/MeshWeaver.Documentation/Data/Architecture/RepositoryTopology.md | Removes atioz from deploy overlay examples list. |
| src/MeshWeaver.Documentation/Data/Architecture/EnvironmentComposition.md | Removes the atioz row from the environment table. |
| src/MeshWeaver.Documentation/Data/Architecture/ControlledIoPooling.md | Rewrites production evidence sentence to remove environment identifier. |
| src/MeshWeaver.Documentation/Data/Architecture/CandidateReleaseProtocol.md | Removes atioz from the rollout configuration table. |
| src/MeshWeaver.Compiler/EmitPipeline.cs | Rewords production log-volume evidence to remove atioz. |
| scripts/check-config-key-coverage.py | Updates docstring example list to remove atioz. |
| memex/Memex.Portal.Shared/SelfUpdate/SelfUpdateHostedService.cs | Rewords production incident comment to remove environment identifier. |
| memex/aspire/Memex.Database.Migration/Migrations/V53_RetypeBuiltinSlideDeckToPublish.cs | Removes atioz from “live mesh” evidence comment. |
| deploy/helm/values.yaml | Removes atioz row/mention from measurement comment block. |
| deploy/helm/templates/memex-portal/config.yaml | Rewords comment evidence/examples to remove atioz. |
| deploy/CHANGE-PROPAGATION.md | Removes atioz row from measurement table and updates surrounding prose accordingly. |
| .github/workflows/release-images.yml | Removes atioz from workflow comment listing deploy environments. |
| .claude/skills/storm/SKILL.md | Removes atioz from outage example reference. |
| .claude/skills/release/SKILL.md | Updates release-skill documentation to remove atioz from rollout descriptions. |
| .claude/skills/pullrequest/SKILL.md | Removes atioz from self-update description. |
| .claude/skills/debug/SKILL.md | Rewords example to remove environment identifier while keeping the incident pattern. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
… (review) Removing atioz left the docstring reading as if memex and memex-cloud were the only possible values. env_of() is generic — it returns whatever the overlay's parent directory is called — so the list is illustrative and should say so, or the next person adding an environment has to re-derive that.
Contributor
Author
|
CI red here is three separate unrelated causes, none of them this PR. This diff is comments, docs, skills and one Python docstring — it cannot reach any of these.
Ruled out explicitly: #2314 is not the cause of the shard-0 failure. It merged at 07:22Z; this run started at 06:47Z, 35 minutes earlier. Re-running the failed jobs, with each cause named above rather than discovered by watching it go green. |
4 tasks done
rbuergi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client-iis a customer-identifying name in a public repository, and the environment is retired — every deployment in the namespace is scaled to0/0and it serves nobody.All 32 references are gone (verified:
grep -ri client-ireturns nothing outside.git).The name goes, the evidence stays
Most references were incident evidence in comments. Deleting those outright would have thrown away why the code looks the way it does, so the edits drop only the name:
Prod (client-i, 2026-08-07) had one RouteMessage turnProd (2026-08-07) had one RouteMessage turnFound live on <c>client-i</c> 2026-08-10, whose 8 …Found live in production 2026-08-10, on an instance whose 8 …THE client-i DEFECT (2026-08-10)THE PRODUCTION DEFECT (2026-08-10)Environment lists lose the entry (
memex/client-i/memex-cloud→memex/memex-cloud). Three measurement tables lose their client-i row — and where the prose counted those rows it is corrected too: CHANGE-PROPAGATION.md said "all three portals" and now says "the portals", so the sentence still matches the table beneath it.Nothing functional moves
This repo never held client-i deployment config — that lives in the private deploy repo. Every helm edit is inside a
#comment, so no YAML structure changed.Companion change in the deploy repo
Systemorph/Memex9994d81: client-i removed fromdeployments/aks/envs.json, the Chart Drift environment matrix. Chart Drift starts working today (#1709), and a retired environment left in the matrix would report drift on every daily run, forever — a gate whose red is permanent is a gate people learn to ignore.Deliberately NOT touched: the
client-inamespace, its PVCs, its database, anddeployments/aks/client-i/. Its data is retained on purpose; deleting the config that could serve that data again is a separate call.Verification
dotnet build -c Release -warnaserror(one project per invocation).DocumentationLinkIntegrityTestpasses, fresh.trx.What's New: skipped — comments, docs and skills only, no user-visible effect.