Northwind dashboard: refer to the classes by the names they actually have by rbuergi · Pull Request #2308 · Systemorph/MeshWeaver

rbuergi · 2026-08-26T06:03:36Z

Northwind/AnalyticsCatalog does not compile. DashboardLayoutAreas.cs names four classes that do not exist:

Referenced	Actual class	Member named
`OrderViews.OrderSummary`	`OrderLayoutAreas`	already declares `OrderSummary`
`SalesViews.SalesByCategory`	`SalesLayoutAreas`	already declares `SalesByCategory`
`SupplierViews.SupplierSummary`	`SupplierLayoutAreas`	already declares `SupplierSummary`
`ProductViews.ProductOverview`	`ProductLayoutAreas`	already declares `ProductOverview`

Northwind/Product then fails after it — Supplier and Category are declared in AnalyticsCatalog's own Source/, so a red root makes the dependent red too.

Behaviour is identical

All four sites are nameof(X.Y), which evaluates to "Y" regardless of X. Every layout-area name passed to Controls.LayoutArea is byte-for-byte what it was. This repairs the compile and changes nothing at runtime.

This is latent on main, not new

In-mesh source compiles at runtime, never in dotnet build — and a NodeType keeps its cached bundle until the framework identity changes, at which point every dynamic NodeType recompiles at once. So this breakage is invisible on main and detonates on the first change that mints a new framework build.

That is how it surfaced: it turned #2285 (which moves types between assemblies) red, on a gate that is green on main with the identical broken file. Worth noting for anyone reading that red as "#2285 broke Northwind" — it did not; it recompiled it.

Verification

Deliberately not verified by dotnet build: samples/Graph/** is <None> content and is never type-checked by any build or test. The Doc content compiles and runs gate is the verification, which is where the failure was observed:

Compilation failed for 'Northwind/AnalyticsCatalog':
  CS0103 'OrderViews' does not exist in the current context   (+3 more)
Compilation failed for 'Northwind/Product':
  CS0246 The type or namespace name 'Supplier' could not be found   (+1 more)
NodeType 'Northwind/Product' PARKED after compile failure

Expected after this change: 31/31 NodeType(s) compiled where the run showed 28/31.

…have DashboardLayoutAreas referenced OrderViews, SalesViews, SupplierViews and ProductViews. No such classes exist — they are OrderLayoutAreas, SalesLayoutAreas, SupplierLayoutAreas and ProductLayoutAreas, and each already declares the exact member being named. So Northwind/AnalyticsCatalog failed to compile, and Northwind/Product failed after it because Supplier and Category are declared in AnalyticsCatalog's own Source. This is latent on main, not new. In-mesh source compiles at runtime, never in `dotnet build`, and a NodeType keeps its cached bundle until the framework identity changes — so the breakage stays invisible until some change mints a new framework build and every dynamic NodeType recompiles at once. The lift in #2285 does exactly that, which is how this surfaced there rather than here. Behaviour is identical: nameof(X.Y) evaluates to "Y" whatever X is, so all four layout-area names are byte-for-byte what they were. This only repairs the compile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Fixes a runtime NodeType compilation failure in the Northwind sample analytics dashboard by updating nameof(...) references to match the actual layout-area classes, ensuring Northwind/AnalyticsCatalog (and downstream Northwind/Product) can compile again during in-portal dynamic compilation. Adds a corresponding “What’s New” entry documenting the user-visible impact (dashboard tiles rendering again).

Changes:

Update DashboardLayoutAreas to reference OrderLayoutAreas, SalesLayoutAreas, SupplierLayoutAreas, and ProductLayoutAreas (instead of non-existent *Views types) while keeping the resulting layout-area names unchanged.
Add a “What’s New” entry describing the restored Northwind analytics dashboard rendering after the compile fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`samples/Graph/Data/Northwind/AnalyticsCatalog/Source/DashboardLayoutAreas.cs`	Corrects `nameof(...)` type qualifiers to match existing layout-area classes so the NodeType compiles again.
`src/MeshWeaver.Documentation/Data/WhatsNew/2026-08-26-northwind-dashboard-compiles.md`	Documents the fix as a user-visible “Fix” entry for the changelog.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-08-26T06:15:56Z

Test Results (shard 3)

9 files ±0 9 suites ±0 6m 9s ⏱️ -2s
1 827 tests ±0 1 823 ✅ ±0 4 💤 ±0 0 ❌ ±0
2 370 runs +1 2 366 ✅ +1 4 💤 ±0 0 ❌ ±0

Results for commit 24d2d27. ± Comparison against base commit b53aed0.