Skip to content

fix(clients): restore the Clients workflow — TypeScript 7 and React 19 broke six of eight jobs #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbuergi wants to merge 1 commit into from
Closed

fix(clients): restore the Clients workflow — TypeScript 7 and React 19 broke six of eight jobs #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clients/grpc-web/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true
"forceConsistentCasingInFileNames": true,
// See clients/react/tsconfig.json — TypeScript 7 stopped auto-including @types, so the Node
// globals restContract/wireContract read had to be named explicitly.
"types": ["node"]
},
"include": ["src"]
}
4 changes: 3 additions & 1 deletion clients/portal/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
"esModuleInterop": true,
"skipLibCheck": true,
"noEmit": true,
"baseUrl": ".",
// No `baseUrl`: TypeScript 7 removed the option. The aliases below are already written
// relative to this file, which is exactly how TS resolves `paths` without a baseUrl, so
// dropping it changes nothing about what they point at.
"paths": {
"@meshweaver/react/core": ["../react/src/core.ts"],
"@meshweaver/react": ["../react/src/index.tsx"],
Expand Down
Loading
Loading