Skip to content

feat(home): restore the "Welcome back" heading to the top of the user home - #155

Merged
rbuergi merged 1 commit into
mainfrom
worktree-home-welcome-heading
Jul 2, 2026
Merged

rbuergi merged 1 commit into
mainfrom
worktree-home-welcome-heading

Conversation

@rbuergi

@rbuergi rbuergi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The user home default template (UserWelcomeMarkdown) had the greeting only in the bottom "it's configurable" note. This brings the welcome back as a heading at the top (above the chat composer) and leaves just the config text at the bottom.

+     ### Welcome back, {ownerName}
+
      @@("area/Composer")
      @@("area/Pinned")
      @@("area/Threads")
      @@("area/Catalog")

-     _Welcome back, {ownerName} — this home is yours to shape. [It's fully configurable](…): …_
+     _This home is yours to shape. [It's fully configurable](…): …_
  • UserWelcomeMarkdown: add ### Welcome back, {ownerName} on top; drop the duplicated greeting from the bottom note (+ doc comment).
  • UserActivityHomeOverrideTest: assert the heading precedes the composer and the config text stays at the bottom.

Verification

  • Release -warnaserror build clean (0/0).
  • UserActivityHomeOverrideTest: 11/11 pass.

🤖 Generated with Claude Code

… home

The user home default template put the greeting only in the bottom "it's
configurable" note. Bring the welcome back as a heading at the TOP (above the
chat composer), and leave just the config text at the bottom.

- UserWelcomeMarkdown: add `### Welcome back, {ownerName}` on top; drop the
  duplicated greeting prefix from the bottom note.
- UserActivityHomeOverrideTest: assert the heading precedes the composer and the
  config text stays at the bottom.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the “Welcome back” greeting as a top-level heading in the default user home markdown template (shown when User.Body is empty), while keeping the bottom note focused on configurability, and updates tests to enforce the intended ordering.

Changes:

  • Updated UserWelcomeMarkdown to add ### Welcome back, {ownerName} at the top and remove the duplicated greeting from the bottom configurable note.
  • Updated the home-template unit test to assert the heading appears before the composer, and that the “configurable” note remains after the regions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/MeshWeaver.Graph.Test/UserActivityHomeOverrideTest.cs Updates assertions to verify the welcome heading is above the composer and the configurable note remains at the bottom.
src/MeshWeaver.Graph/UserActivityLayoutAreas.cs Adjusts the default welcome markdown template to place the greeting as a top heading and de-duplicate the bottom note text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 1)

923 tests  +242   922 ✅ +241   3m 54s ⏱️ + 1m 32s
 13 suites ±  0     1 💤 +  1 
 13 files   ±  0     0 ❌ ±  0 

Results for commit ecaa7d0. ± Comparison against base commit 2ea6880.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 3)

1 055 tests  ±0   1 055 ✅ ±0   5m 24s ⏱️ -1s
   12 suites ±0       0 💤 ±0 
   12 files   ±0       0 ❌ ±0 

Results for commit ecaa7d0. ± Comparison against base commit 2ea6880.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 0)

2 179 tests  +657   2 174 ✅ +652   9m 25s ⏱️ + 6m 6s
   13 suites +  1       5 💤 +  5 
   13 files   +  1       0 ❌ ±  0 

Results for commit ecaa7d0. ± Comparison against base commit 2ea6880.

This pull request removes 1 and adds 658 tests. Note that renamed tests count towards both.
MeshWeaver.Graph.Test.UserActivityHomeOverrideTest ‑ OwnerHome_WelcomeTemplate_EmbedsRegions_ComposerOnTop_TextAtBottom
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Progress_Messages_Stream_Gradually_Not_Just_At_The_End
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Script_Failure_Flips_ActivityLog_Status_To_Failed
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Script_Log_Messages_Land_On_ActivityLog_Node
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithContextPath_ConcurrentCallers_DoNotDeadlock
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithContextPath_SingleCaller_ResolvesQuickly
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithMarkdownContext_DoesNotDeadlock
MeshWeaver.AI.Test.AgentChatClientTest ‑ AgentChatClient_Initialize_SurfacesPartitionAgents_NotNodeTypeNamespaceAgents
MeshWeaver.AI.Test.AgentChatClientTest ‑ AgentChatClient_Initialize_SurfacesPlatformAgentsForAnyContext
MeshWeaver.AI.Test.AgentChatClientUnitTest ‑ FindCyclicDelegations_Chain_ReturnsEmpty
MeshWeaver.AI.Test.AgentChatClientUnitTest ‑ FindCyclicDelegations_DelegationsWithNoMatchingTarget_ReturnsEmpty
…

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Test Results (shard 2)

   13 files  ±0     13 suites  ±0   7m 23s ⏱️ -18s
1 269 tests ±0  1 266 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 297 runs  ±0  1 294 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit ecaa7d0. ± Comparison against base commit 2ea6880.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Test Results

   51 files  +  1     51 suites  +1   26m 7s ⏱️ + 7m 21s
5 426 tests +899  5 417 ✅ +893  9 💤 +6  0 ❌ ±0 
5 454 runs  +899  5 445 ✅ +893  9 💤 +6  0 ❌ ±0 

Results for commit ecaa7d0. ± Comparison against base commit 2ea6880.

This pull request removes 1 and adds 900 tests. Note that renamed tests count towards both.
MeshWeaver.Graph.Test.UserActivityHomeOverrideTest ‑ OwnerHome_WelcomeTemplate_EmbedsRegions_ComposerOnTop_TextAtBottom
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Progress_Messages_Stream_Gradually_Not_Just_At_The_End
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Script_Failure_Flips_ActivityLog_Status_To_Failed
MeshWeaver.AI.Test.ActivityLogStreamTest ‑ Script_Log_Messages_Land_On_ActivityLog_Node
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithContextPath_ConcurrentCallers_DoNotDeadlock
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithContextPath_SingleCaller_ResolvesQuickly
MeshWeaver.AI.Test.AgentChatClientDeadlockTest ‑ GetOrderedAgentsAsync_WithMarkdownContext_DoesNotDeadlock
MeshWeaver.AI.Test.AgentChatClientTest ‑ AgentChatClient_Initialize_SurfacesPartitionAgents_NotNodeTypeNamespaceAgents
MeshWeaver.AI.Test.AgentChatClientTest ‑ AgentChatClient_Initialize_SurfacesPlatformAgentsForAnyContext
MeshWeaver.AI.Test.AgentChatClientUnitTest ‑ FindCyclicDelegations_Chain_ReturnsEmpty
MeshWeaver.AI.Test.AgentChatClientUnitTest ‑ FindCyclicDelegations_DelegationsWithNoMatchingTarget_ReturnsEmpty
…

@rbuergi
rbuergi merged commit 583764c into main Jul 2, 2026
12 checks passed
@rbuergi
rbuergi deleted the worktree-home-welcome-heading branch August 7, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants