Repository navigation
fix(graph): a cell that never ran shows no output pane at all - #1468
Merged
Merged
Conversation
An unrun executable cell rendered an italic "Not yet run." strip in its output segment. Once the toolbar moved above the output (#1463) that strip became a dead empty box hanging off the bottom of every unrun cell — directly under the accent Run button that is the answer to it. The segment is now rendered only when there IS a run to show. Press Run and the node gains a LastActivityPath, so the pane appears with the live log in it; until then the cell simply ends after the toolbar. CodeCellLayoutTest pins the absence before the first run, and the run test — which actually has an output to order — now pins the full reading order CODE → TOOLBAR → OUTPUT. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the Code cell UX in MeshWeaver.Graph by removing the “Not yet run.” output placeholder for executable cells that have never been executed, so the cell renders only CODE → TOOLBAR until a run stamps LastActivityPath, at which point the OUTPUT segment appears and embeds the live activity progress/log.
Changes:
- Update
CodeLayoutAreas.Contentrendering to omit the output segment entirely unlessLastActivityPathis present. - Adjust
CodeCellLayoutTestto assert the output area is absent before first run and to pin the CODE → TOOLBAR → OUTPUT ordering in the post-run state. - Clarify the
CodeLayoutAreasdocumentation comments to reflect the conditional output rendering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/MeshWeaver.AI.Test/CodeCellLayoutTest.cs | Updates layout assertions to expect no output area before first run and verifies ordering once output exists. |
| src/MeshWeaver.Graph/CodeLayoutAreas.cs | Removes the “Not yet run.” placeholder output view; output is rendered only when LastActivityPath is set. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An executable Code cell that has never run rendered an italic "Not yet run." strip in its output segment. Now it renders no output segment at all — the cell ends after the toolbar. Press Run, the node gains a
LastActivityPath, and the pane appears with the live log in it.Why
Maintainer feedback on the deployed cell: "it looks like this when it was not run ⇒ say to run or hide it." Once #1463 moved the toolbar above the output, that strip became a dead empty box hanging off the bottom of every unrun cell — a status nobody needs, sitting directly under the accent Run button that is the answer to it. Absence says the same thing and says it quieter.
Tested
MeshWeaver.AI.Testcell suites 10/10:CodeCellLayoutTestnow asserts the output area is absent before the first run, and the run test — which actually has an output to order — pins the full reading order CODE → TOOLBAR → OUTPUT (it previously could only be asserted in the state where the output was an empty placeholder).MeshWeaver.Graph.Test1114/1114.dotnet build -c Release -p:CIRun=true -warnaserrorclean.🤖 Generated with Claude Code