Skip to content

The clamp comment described the wrong failure #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuergi merged 2 commits into from
Aug 13, 2026
Merged

The clamp comment described the wrong failure #1407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbd190
review: curl, not wget — the hook would have hung every roll
rbuergi Aug 13, 2026
b916263
Merge remote-tracking branch 'origin/main' into feat/circuit-drain-on…
rbuergi Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/MeshWeaver.Hosting/ActiveCircuitTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ public sealed class ActiveCircuitTracker

/// <summary>
/// Records a circuit closing. Clamped at zero: a double-close (Blazor can report a circuit
/// closed after a connection-down that already ended it) must never push the count negative —
/// a negative count reads as "drained" forever after, which would hand back the very kill this
/// exists to prevent.
/// closed after a connection-down that already ended it) must never push the count negative.
/// <see cref="Drained"/> is <c>Count == 0</c>, so a negative count reads as "still busy" and
/// the pod would sit out its whole grace period on every roll before being SIGKILLed — and
/// then the NEXT open would only bring it back to zero, so a live session would read as
/// drained and get cut off. Both directions are wrong; the clamp removes both.
/// </summary>
public void Closed()
{
Expand Down
Loading