Activity log: roll severity and message count into counters (1/3) by rbuergi · Pull Request #1398 · Systemorph/MeshWeaver

rbuergi · 2026-08-13T08:07:23Z

Merge order: 1 of 3. Stacked ahead of #1399 and #1400 — merge this one first.

Part of the activity satellite migration (#1284 / #1351). This PR is the prerequisite refactor; the actual window + segments land in 2/3.

The problem

An activity's terminal status was a function of its message list: Finish() computed it from Messages.Max(LogLevel) and HasErrors() scanned the list. Both are O(list), and — the reason this blocks the migration — both silently change meaning the moment Messages stops holding the whole transcript.

What this does

Two incremental roll-ups on ActivityLog:

field	meaning
`MessageCount`	total messages ever appended (read via `TotalMessageCount`, which falls back to `Messages.Count` for logs persisted before the field existed)
`MaxSeverity`	highest `LogLevel` ever appended (default `Trace` — the identity element of the max, so a legacy log rolls up to exactly what a scan of its `Messages` yields)

ActivityLog.Append(...) becomes the one way to add messages and advances both in the same step. Every append site in src/ is migrated to it, including the fresh-log initialisers that assigned Messages wholesale. GetFinalStatus() / HasErrors() fold the counter together with the list, so they answer identically before and after the list is trimmed.

Two behaviour corrections fall out

Both are required for the counter and the list to agree — that agreement is what makes the window safe in 2/3:

LogLevel.None is excluded from the status fold. It is numerically above Critical but means "no logging", so one None entry became the list's Max and dropped the whole activity into the Succeeded arm, swallowing a real Error logged beside it. Caught by a new test, not by inspection.
HasErrors() now also reports Critical, matching Errors(), which has always included it.

`RunningActivitiesStripe` (the landmine this defuses early)

The stripe keys its DistinctUntilChanged on the message count. Moved to TotalMessageCount: keying on the in-list count would freeze the stripe for exactly the long-running activities it exists to show, once that list becomes a window in 2/3.

Verification

ActivityLogRollupTest (new, pure, 15 cases) — the roll-ups, the None rule, the sub-activity fold, and a back-compatibility half asserting a pre-roll-up log (MessageCount = 0, MaxSeverity = Trace) produces byte-identical answers.
MeshWeaver.Data.Test 344/344 · MeshWeaver.Graph.Test 1095/1095 · MeshWeaver.GitSync.Test 161/161 · MeshWeaver.AI.Test activity filter 34/34.
Solution build clean under -c Release -p:CIRun=true -warnaserror (0 warnings, 0 errors).

🤖 Generated with Claude Code

An activity's terminal status was a function of its message LIST: `Finish()` computed it from `Messages.Max(LogLevel)` and `HasErrors()` scanned the list. Both are O(list) and — the reason this matters — both silently change meaning the moment `Messages` stops holding the whole transcript. Add two incremental roll-ups to `ActivityLog`: MessageCount — total messages ever appended (read via TotalMessageCount, which falls back to Messages.Count for logs persisted before the field existed) MaxSeverity — highest LogLevel ever appended (default Trace = the identity element of the max, so a legacy log rolls up to exactly what a scan of its Messages yields) `ActivityLog.Append(...)` is now the ONE way to add messages; it advances both roll-ups in the same step. Every append site in src/ is migrated to it, including the fresh-log initialisers that used to assign `Messages` wholesale. `GetFinalStatus()`/`HasErrors()` now fold the counter together with the list, so they answer identically before and after the list is trimmed. Two behaviour corrections fall out, both required for the counter and the list to agree: - `LogLevel.None` is excluded from the status fold. It is numerically above Critical but means "no logging", so one None entry became the list's Max and dropped the whole activity into the Succeeded arm, swallowing a real Error logged beside it. - `HasErrors()` now also reports Critical, matching `Errors()`, which has always included it. `RunningActivitiesStripe` keys its `DistinctUntilChanged` on the message count. Moved to `TotalMessageCount`: keying on the in-list count would freeze the stripe for exactly the long-running activities it exists to show, once that list becomes a window. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR is the first step in the activity-satellite migration, refactoring ActivityLog so an activity’s derived state (final status and “has errors”) can be computed from incremental counters (MessageCount, MaxSeverity) rather than scanning the full Messages list—preserving semantics once Messages becomes a bounded window.

Changes:

Introduces ActivityLog.MessageCount / MaxSeverity roll-ups and a canonical ActivityLog.Append(...) API to advance them.
Migrates in-repo activity log append sites to Append(...) and updates the running-activities stripe to key off TotalMessageCount.
Adds a new unit test suite and a “What’s New” entry covering the status fold corrections.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/MeshWeaver.Data.Test/ActivityLogRollupTest.cs	Adds regression tests for the roll-ups and back-compat behavior.
src/MeshWeaver.Mesh.Contract/MeshExtensions.cs	Updates activity log construction to use `Append(...)` so counters advance with message writes.
src/MeshWeaver.Hosting/Persistence/MonotonicWriteGuardStorageAdapter.cs	Records write-conflict activities using `Append(messages)` rather than overwriting `Messages`.
src/MeshWeaver.Graph/RunningActivitiesStripe.cs	Switches UI caption + `DistinctUntilChanged` key to `TotalMessageCount` for future windowing.
src/MeshWeaver.Graph/Configuration/NodeTypeCompilationActivity.cs	Routes compilation activity message writes through `ActivityLog.Append(...)`.
src/MeshWeaver.Graph/Configuration/MeshNodeCompilationService.cs	Refactors helper append methods to use `Append(...)`.
src/MeshWeaver.GitSync/ActivityRunner.cs	Updates append/finish logging paths to use `Append(...)`.
src/MeshWeaver.Documentation/Data/WhatsNew/2026-08-13-activity-status-from-counters.md	Documents the behavior change/fix for activity status derivation.
src/MeshWeaver.Data/WorkspaceOperations.cs	Uses `Append(messages)` when creating/finalizing data-update activity logs.
src/MeshWeaver.Data/Activity.cs	Updates logger mutation helpers to append via `Append(...)`.
src/MeshWeaver.Data.Contract/ActivityLog.cs	Adds the counters + `Append(...)` and updates status/error derivation logic.
src/MeshWeaver.ContentCollections.Indexing.Graph/ContentIndexingActivity.cs	Migrates indexing activity logging to `Append(...)`.

Suppressed comments (1)

src/MeshWeaver.Data.Contract/ActivityLog.cs:211

HasErrors() claims to report Error or Critical, but for legacy logs (where MaxSeverity is still the default) it only scans Messages for LogLevel.Error. A legacy log that contains only a Critical entry will incorrectly return false, and it also diverges from ActivityLogExtensions.Errors() which includes Critical.

    public bool HasErrors() =>
        MaxSeverity is LogLevel.Error or LogLevel.Critical
        || Messages.Any(m => m.LogLevel == LogLevel.Error);

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    public ActivityLog Append(IReadOnlyList<LogMessage> messages)
+    {
+        if (messages.Count == 0) return this;
+        var severity = MaxSeverity;
+        foreach (var m in messages)
+            if (m.LogLevel > severity && m.LogLevel != LogLevel.None)
+                severity = m.LogLevel;
+        return this with
+        {
+            Messages = Messages.AddRange(messages),
+            MessageCount = TotalMessageCount + messages.Count,
+            MaxSeverity = severity,
+        };
+    }


+    [InlineData(LogLevel.Trace, ActivityStatus.Succeeded, false)]
+    [InlineData(LogLevel.Information, ActivityStatus.Succeeded, false)]
+    [InlineData(LogLevel.Warning, ActivityStatus.Warning, false)]
+    [InlineData(LogLevel.Error, ActivityStatus.Failed, true)]
+    public void LegacyLog_WithoutRollups_AnswersFromTheListExactlyAsBefore(


github-actions · 2026-08-13T08:21:59Z

Test Results (shard 0)

723 tests 723 ✅ 9m 13s ⏱️
10 suites 0 💤
10 files 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:22:47Z

Test Results (shard 3)

11 files 11 suites 5m 42s ⏱️
1 764 tests 1 659 ✅ 105 💤 0 ❌
2 056 runs 1 951 ✅ 105 💤 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:22:55Z

Test Results (shard 5)

1 906 tests 1 714 ✅ 5m 18s ⏱️
11 suites 192 💤
11 files 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:23:58Z

Test Results (shard 4)

1 949 tests 1 941 ✅ 8m 7s ⏱️
11 suites 8 💤
11 files 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:25:51Z

Test Results (shard 1)

1 419 tests 1 419 ✅ 6m 48s ⏱️
11 suites 0 💤
11 files 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:26:10Z

Test Results (shard 2)

2 438 tests 2 437 ✅ 7m 6s ⏱️
12 suites 1 💤
12 files 0 ❌

Results for commit b7cae6d.

github-actions · 2026-08-13T08:26:38Z

Test Results

66 files 66 suites 42m 16s ⏱️
10 199 tests 9 893 ✅ 306 💤 0 ❌
10 491 runs 10 185 ✅ 306 💤 0 ❌

Results for commit b7cae6d.

rbuergi and others added 2 commits August 13, 2026 09:26

docs: What's New — activity status no longer misses errors

b7cae6d

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot AI lite review requested due to automatic review settings August 13, 2026 08:07

rbuergi mentioned this pull request Aug 13, 2026

Activity log: bound the message list, flush overflow to segment satellites (2/3) #1399

Merged

Copilot started reviewing on behalf of rbuergi August 13, 2026 08:07

View session

rbuergi mentioned this pull request Aug 13, 2026

Approval and write-conflict activities: use the canonical activity shape (3/3) #1400

Merged

Copilot AI reviewed Aug 13, 2026

View reviewed changes

rbuergi merged commit 58b3abf into main Aug 13, 2026
20 checks passed

rbuergi deleted the feat/1284-activity-log-rollup branch August 19, 2026 10:29

Navigation Menu

Repository navigation

Activity log: roll severity and message count into counters (1/3) - #1398

Activity log: roll severity and message count into counters (1/3)#1398
rbuergi merged 2 commits into
mainfrom
feat/1284-activity-log-rollup

rbuergi commented Aug 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rbuergi commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The problem

What this does

Two behaviour corrections fall out

RunningActivitiesStripe (the landmine this defuses early)

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 0)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 3)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 5)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 4)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 1)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results (shard 2)

Uh oh!

github-actions Bot commented Aug 13, 2026

Test Results

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rbuergi commented Aug 13, 2026 •

edited

Loading

`RunningActivitiesStripe` (the landmine this defuses early)