Repository navigation
fix(field): stop the knife deleting the object when the cut fails - #163
Merged
Merged
Conversation
A cut deleted the selected traces before it looked at the result, so a trace that cannot be cut as a polygon (a self-crossing outline, which the shapely library refuses) was removed with nothing put back. The cut is now refused up front, a click with no drag leaves the section alone, and an empty result is refused. A press of another mouse button mid-stroke no longer cancels the cut and opens the field menu over the object; a knife option turns that back on. Issue #48.
dustenhubbard
added
the
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cutting with the knife deleted the selected traces before it looked at the result, so a trace that cannot be cut as a polygon, such as an outline that crosses itself, vanished with no message. The cut is now refused up front, and a click with no drag or an empty result leaves the section alone. A press of another mouse button mid-stroke no longer cancels the cut.
Closes #48