Repository navigation
feat(dialog): offer the tags already in the series in Set Attributes - #161
Merged
Merged
Conversation
The Tags rows of Set Attributes are now dropdowns listing every tag on a trace in the series, completing as you type. Typed text outside the list is still accepted. The trace, object and palette dialogs all get the list, read from the series data so no section file is opened. Issue #132.
dustenhubbard
added
the
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags in
Set Attributeshad to be typed from memory, so one tag ended up spelled three ways. EachTagsrow is now a dropdown of every tag already on a trace in the series, completing as you type. Text outside the list is still accepted, so a new tag goes in as before. The trace, object and palette dialogs all get the list, without opening a section file.Closes #132