Repository navigation
feat(sections): show progress on bulk section edits - #160
Merged
Merged
Conversation
Brightness/contrast and thickness edits over many sections load and save each one with nothing on screen. They now share the progress bar that locking already had; a single section still shows no dialog. Also fixes the thickness accumulator, which built a set and discarded it. Issue #139.
dustenhubbard
added
the
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the thickness or the brightness and contrast of many sections loads, edits and saves each one with nothing on screen, so a whole series looks stuck for a minute. Locking already showed a progress bar. The three now share one helper that drives the bar; a single section still shows no dialog. The thickness edit also discarded its set of modified objects, so its object list refresh never ran.
Closes #139