Fix typo of URL of sbol data model specification #425
Fix typo of URL of sbol data model specification #425tcmitchell merged 7 commits intoSynBioDex:mainfrom
Conversation
tcmitchell
left a comment
tcmitchell
left a comment
There was a problem hiding this comment.
Please remove the changes to .gitignore, or explain why they are necessary.
| dist/ | ||
| # Emacs backup files | ||
| *~ | ||
| test/SBOLTestSuite |
There was a problem hiding this comment.
Why is this being ignored? Is this part of the URL change? I don't think this is right.
|
This is a good catch, thanks for updating the URL. The sbolstandard web site was migrated last year and the URL must have changed as part of that migration. You are correct that the URL should be updated in |
tcmitchell
left a comment
tcmitchell
left a comment
There was a problem hiding this comment.
Please revert .gitignore since there are no changes other than whitespace.
tcmitchell
left a comment
tcmitchell
left a comment
There was a problem hiding this comment.
Please revert .gitignore since there are no changes other than whitespace. You'll know you have reverted it properly when it no longer appears in this pull request.
.vscode folder was created automatically when I run unittest for specific branch. I found that this folder was unnecessary, so I have deleted it and removed from gitignore file
|
Finally reverted the file Now, the .gitignore file in my branch is the same as the one on the main |
Omarelsherif010
changed the title
2 participants
Inside
constant.pyfile the URL of SBOL data model specification is not correct.I am not sure if it is better to change the URL itself to look like the one written in file or change the one in file for now until next update.
currently this make the URL inside the file send the user to SBOL data model specification website.
fixes #424