Remove blank line from N-Triples output#405
Merged
tcmitchell merged 1 commit intoSynBioDex:mainfrom Jun 14, 2022
Merged
Conversation
Remove the extra blank line in N-Triples output that RDFLib includes. Filter the blank line out in both N-Triples and Sorted N-Triples formats.
jakebeal
reviewed
Jun 14, 2022
| if lines_type is bytes: | ||
| # rdflib 5 | ||
| return b''.join(lines) | ||
| return b'\n'.join(lines) + b'\n' |
Contributor
There was a problem hiding this comment.
Will this cause any issue for Windows expecting its "two-character newline", or is string-writing smart about that?
Collaborator
Author
There was a problem hiding this comment.
Great question. Looking at the documentation for os.linesep it seems like '\n' (or b'\n') is the right thing to use, and that lower level stuff handles platform specific line endings. The documentation says:
Do not use os.linesep as a line terminator when writing files opened in text mode (the default); use a single
'\n'instead, on all platforms.
My conclusion is that we are doing the right thing by using '\n' (or b'\n').
jakebeal
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the extra blank line in N-Triples output that RDFLib includes.
Filter the blank line out in both N-Triples and Sorted N-Triples formats.
Closes #404