Skip to content

Add __str__ function for ValidationReport#364

Merged
tcmitchell merged 4 commits intoSynBioDex:mainfrom
arsalan0c:str
Jan 11, 2022
Merged

Add __str__ function for ValidationReport#364
tcmitchell merged 4 commits intoSynBioDex:mainfrom
arsalan0c:str

Conversation

@arsalan0c
Copy link
Copy Markdown
Contributor

Hi! This is a PR for #232.

@jakebeal
Copy link
Copy Markdown
Contributor

Looks like it's not meeting the Python recommended style requirements, which we're being strict about to make library use easier. If you check in your IDE, it will likely have style warnings.

@jakebeal
Copy link
Copy Markdown
Contributor

Looks good, thank you!

@tcmitchell
Copy link
Copy Markdown
Collaborator

@arsalan0c thank you! Thanks very much for contributing, I appreciate it very much. I'm sorry for the lengthy delay, I have been away enjoying the end of year holidays. I'm about to review your code. I'd like to see a few changes if you don't mind. I consider this a conversation though, so if you don't want to make some of these changes let me know.

Most importantly, though, great job! I really appreciate the addition of the unit test.

Comment thread sbol3/validation.py Outdated
Comment thread sbol3/validation.py Outdated
Comment thread test/test_validation.py Outdated
@arsalan0c
Copy link
Copy Markdown
Contributor Author

Glad to make changes, thanks for the suggestions!

@tcmitchell tcmitchell self-requested a review January 11, 2022 15:11
@tcmitchell tcmitchell merged commit 5cdbdfc into SynBioDex:main Jan 11, 2022
@tcmitchell
Copy link
Copy Markdown
Collaborator

Nice job @arsalan0c! Thanks very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants