Add collections of TopLevel via Document.add()#333
Merged
tcmitchell merged 4 commits intoSynBioDex:mainfrom Oct 18, 2021
Merged
Add collections of TopLevel via Document.add()#333tcmitchell merged 4 commits intoSynBioDex:mainfrom
tcmitchell merged 4 commits intoSynBioDex:mainfrom
Conversation
Expand `Document.add` to allow a user to specify a TopLevel or a Collection of TopLevel. Change `Document.add` to return its argument on success.
`Document.add` takes a Sequence, not an Iterable. Generators are iterable, but Document.add doesn't really handle them. And it doesn't need to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand
Document.addto allow a user to specify a TopLevel or a Collection of TopLevel. ChangeDocument.addto return its argument on success.Closes #272
Closes #311