Merged
Conversation
loic425
force-pushed
the
docs/ddd
branch
7 times, most recently
from
21bd14c to
4ac1bab
Compare
loic425
force-pushed
the
docs/ddd
branch
11 times, most recently
from
ef0bb41 to
73a35b6
Compare
diimpp
reviewed
Dec 23, 2024
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
stlgaits
requested changes
Jan 2, 2025
| } | ||
| ``` | ||
|
|
||
| The idea is to reuse this command to create the book in the storage for your "create" operation. |
Contributor
There was a problem hiding this comment.
I'm not sure how but I think this sentence should be rephrased to be less repetitive
| { | ||
| public function apply(DataSourceInterface $dataSource, string $name, $data, array $options): void | ||
| { | ||
| throw new \RuntimeException('Not implemented'); // We cannot use the DataSource generic abstraction |
Contributor
There was a problem hiding this comment.
maybe worth explaining why not?
Member
Author
There was a problem hiding this comment.
Hum indeed, that could be interesting to add this on the cookbook.
Member
Author
There was a problem hiding this comment.
I've opened this issue with that comment
#202
stlgaits
approved these changes
Jan 3, 2025
Co-authored-by: Estelle Gaits <74190794+stlgaits@users.noreply.github.com>
Co-authored-by: Estelle Gaits <74190794+stlgaits@users.noreply.github.com> Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
diimpp
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.