Skip to content

refactor(gc): stabilize Dota GC state and domain boundaries - #18

Open
Svenmax wants to merge 760 commits into
devfrom
260728-refactor-gc-domain-boundary-cleanup
Open

refactor(gc): stabilize Dota GC state and domain boundaries#18
Svenmax wants to merge 760 commits into
devfrom
260728-refactor-gc-domain-boundary-cleanup

Conversation

@Svenmax

@Svenmax Svenmax commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Consolidate Dota GC translation units and reduce low-value file fragmentation.
  • Add source-aware Local/shared lobby restore and adopt guards for common field groups.
  • Expand audit/offline coverage and document GC domain boundary cleanup direction.

Verification

  • git diff --check
  • python3 tools/test_audit_gc_refactor.py
  • bash tools/run_gc_offline_tests.sh --full
  • bash tools/check_gc_production_tus.sh --jobs 4

Notes

Svenmax added 30 commits July 11, 2026 07:11
@Svenmax
fix(gc): restore host cosmetic cache
030cb09
@Svenmax
fix(gc): avoid duplicate host cache subscribe
4023feb
@Svenmax
fix(gc): refresh host local cosmetics
d4727bb
@Svenmax
fix(gc): advance host cosmetic cache version
22473e7
@Svenmax
fix(gc): rebuild host local item cache
56470b6
@Svenmax
fix(gc): mirror host equipped inventory
40daa96
@Svenmax
fix(gc): preserve remote equipped inventory
06bcf38
@Svenmax
fix(gc): refresh host local wearables
ff07431
@Svenmax
fix(gc): defer host wearable refresh
8b1c368
@Svenmax
fix(gc): update host client wearables
51051f8
@Svenmax
fix(gc): include item payload helpers
3795a5e
@Svenmax
fix(gc): refresh host loadout cache
fd74db8
@Svenmax
fix(gc): retry host wearable refresh
2822540
@Svenmax
fix(gc): route host wearable refresh to server
55ad1ef
@Svenmax
chore(gc): trace equipped cache baseline
71bd1e8
@Svenmax
fix(gc): expose lobby generation diagnostic
dfb6334
@Svenmax
fix(gc): align host equip payload encoding
7fb7b28
@Svenmax
fix(gc): infer host hero before equip replay
5385db7
@Svenmax
fix(gc): validate host lobby across gc identities
7598f91
@Svenmax
fix(gc): keep host lobby check in coordinator
db7c7ce
@Svenmax
fix(gc): retain inferred host hero on client
4b1d6e6
@Svenmax
fix(gc): preserve known shared owner hero
9137d0b
@Svenmax
fix(gc): retain known hero across lobby restore
3d47061
@Svenmax
fix(gc): include host hero in 7034 response
0e98eca
@Svenmax
fix(gc): recover host hero before showcase
9e836ba
@Svenmax
fix(gc): route hero restore through lifecycle
1b9246e
@Svenmax
fix(gc): synchronize hero wearable lifecycle
bbd0533
@Svenmax
refactor(gc): single-track deferred tasks via Slot only
537ddc4 
Remove bool+lobby_id parallel fields for abandon/signout/reset deferred
work; Has/Set/Clear/Consume operate only on GBE_DotaDeferredTaskSlot.
Sync handler-test stubs and smoke asserts; keep dual_gc host gate green.
@Svenmax
refactor(gc): centralize owner_hero_id apply and preserve rules
331a0b4 
Extract preserve/peer-restore/apply helpers in lobby_state; route GC
owner hero writes through GBE_ApplyOwnerHeroId; dual_gc H1/H5 use
production rules (H5c apply API).
@Svenmax
refactor(gc): share host showcase/wearable one-shot key rules
883d505 
Extract host_*_key_matches helpers; HasPushed/HasRefreshed and dual_gc
H2-H4 use the same generation-bound match. Document 7034/2569 equip
order; verification --fast green.
Svenmax and others added 30 commits July 27, 2026 02:36
@Svenmax
refactor(gc): publish local member from owner snapshot
3cf5a87
@Svenmax
refactor(gc): publish metadata from owner snapshot
95f97e8
@Svenmax
refactor(gc): route cache metadata through owner snapshot
fbf5553
@Svenmax
refactor(gc): guard lobby capture from owner snapshot
9a7e7ad
@Svenmax
refactor(gc): route slot handler reads through owner snapshot
977e413
@Svenmax
refactor(gc): route owner transfer reads through snapshot
c8c5462
@Svenmax
refactor(gc): route small lobby reads through snapshot
8e5c8a5
@Svenmax
refactor(gc): route lifecycle diagnostic reads through snapshot
4a0dfc4
@Svenmax
refactor(gc): route custom lifecycle handler reads through snapshot
c881642
@Svenmax
refactor(gc): route inventory handler reads through snapshot
8934188
@Svenmax
refactor(gc): route join handler reads through snapshot
1ccc245
@Svenmax
refactor(gc): route inventory coordinator reads through snapshot
62699db
@Svenmax
refactor(gc): route connection lifecycle reads through snapshot
fd36c16
@Svenmax
refactor(gc): route post-login lobby reads through snapshot
d7e4cc6
@Svenmax
refactor(gc): route recover lobby reads through snapshot
b8be977
@Svenmax
refactor(gc): route launch lobby reads through snapshot
b1f746a
@Svenmax
refactor(gc): route restore lobby reads through snapshot
6f6d6bb
@Svenmax
refactor(gc): route create lobby reads through snapshot
e49aab2
@Svenmax
refactor(gc): route misc lobby reads through snapshot
996455b
@Svenmax
refactor(gc): route welcome lobby reads through snapshot
a5247aa
@Svenmax
refactor(gc): route chat lobby reads through snapshot
6b6cc0c
@Svenmax
refactor(gc): route coordinator lobby reads through snapshot
0affe13
@Svenmax
refactor(gc): route lifecycle lobby reads through snapshot
927d9dc
@Svenmax
refactor(gc): consolidate lobby translation units
a9bbba4
@Svenmax
refactor(gc): add source-aware local lobby restore guards
2a447b8
@Svenmax
refactor(gc): preserve cache metadata during shared adopt
c720ffe
@Svenmax
docs(gc): record domain boundary cleanup plan
90d0508
@Svenmax
fix(ci): checkout common deps for gc verification
c8f0a66
@Svenmax
refactor(gc): extract GBE_DotaLobbyCacheMetadata DTO from GBE_LocalLo…
01111c2 
…bby cache fields
@MonkeyCode-AI
fix(gc): preserve custom game lifecycle action order
7328429 
Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Svenmax @MonkeyCode-AI