Rename ACL preparation functions and add a convenient helper#34
Merged
Conversation
cedricjiang
commented
Oct 28, 2025
| /// with the transaction sender as the requester. | ||
| /// | ||
| /// @dev see `prepareContractRunAccess` and `requestAclAsSender` | ||
| function senderAllowCurrentContractRun(SpfParameter memory ciphertext, SpfLibrary lib, SpfProgram prog) |
Contributor
Author
There was a problem hiding this comment.
@ryanorendorff this is what you ask for, note that pushing this requires changing our docs because of the function renames, this also requires changes to some other repos that use this as submodules (if they update to this version), not urgent but better do them sooner than later
Contributor
There was a problem hiding this comment.
I would rename this allowContractRun or something like that; the sender is ideally implied.
Contributor
Author
There was a problem hiding this comment.
the name is potentially confusing if you have a version similar to this just requestAclAsContract
ryanorendorff
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.