Skip to content

Fix admission and compression correctness gaps - #8

Merged
SunSi12138 merged 2 commits into
devfrom
feature/issue-7-correctness
Jul 21, 2026
Merged

SunSi12138 merged 2 commits into
devfrom
feature/issue-7-correctness

Conversation

@SunSi12138

@SunSi12138 SunSi12138 commented Jul 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • retain non-refundable receive-credit accounting and the related correctness coverage
  • keep Brotli as the sole built-in compression provider; use the platform Brotli decoder's consumption reporting to reject trailing compressed data, removing the custom gzip/DEFLATE boundary parser
  • negotiate providers through WireProfile; encode decode-relevant provider settings in that profile, with other compression algorithms supplied by custom providers
  • keep the compression-provider contract synchronous and preserve exact consumed/written-byte reporting
  • update documentation, benchmark scripts, package smoke coverage, and integration tests for the Brotli-only built-in surface

Validation

  • dotnet build SharpLink.slnx --configuration Release --no-incremental --verbosity minimal (0 warnings, 0 errors)
  • dotnet test --solution SharpLink.slnx --configuration Release --no-build --verbosity minimal (454 passed)
  • Release pack plus local package-smoke test
  • NativeAOT shared-memory independent-process smoke test (osx-arm64)

API note

ISharpLinkCompressionProvider.Algorithm is now WireProfile; built-in gzip and deflate factory methods are removed. Applications that need other formats can negotiate a custom provider by supplying its wire-profile token.

Closes #7

Repository owner deleted a comment from chatgpt-codex-connector Bot Jul 21, 2026
@SunSi12138
SunSi12138 merged commit faac683 into dev Jul 21, 2026
1 check passed
@SunSi12138
SunSi12138 deleted the feature/issue-7-correctness branch July 22, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant