Repository navigation
feat(telemetry): update SharpLink detail policy at runtime - #600
Merged
Merged
Conversation
SunSi12138
marked this pull request as ready for review
September 8, 2026 05:51
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
Audit boundary
The repository currently has no SharpLink-owned
ActivityEventemission sites, so this PR does not invent a parallel diagnostic event stream. OpenTelemetry sampler/exporter/provider ownership and the stableSharpLink.Client,SharpLink.Server, andSharpLinksource/meter identities remain unchanged.Runtime policy
Adds one immutable SharpLink-owned telemetry detail generation on both Client and Server.
Detailedis the default and preserves the historical telemetry surface.Basicretains logical call activities, stable RPC identity tags, core metrics, and bounded resource-exhaustion classification.Basicsuppresses existing optional diagnostic/high-cardinality trace detail: Server request identity, Client lifetime-source enrichment, and retry-attempt child activities.ResolvedCallControl; interceptor suspension, delayed stream enumeration, retry backoff, and later retry attempts therefore cannot mix detail generations within one logical RPC.Ownership boundary
This API does not implement or replace OpenTelemetry sampling, exporters, processors/providers, resource configuration, or listener lifecycle. It does not replace/rename
ActivitySource,Meter, or metric instruments.doc/observability.mddocuments this boundary explicitly.Regression coverage
SharpLinkRuntimeTelemetryDetailPolicyTestscovers:Activity.Currentand emitting no attempt child Activity;Branch head:
94a60fb977b76af1cbef18a3b3021965d0d1dde1.Validated target:
dev@3bccdefd75fbb1f7e04ad6816f615d198004230e.Validation
34192031561: PASS.34192220272: PASS.34192031623: PASS.34192232906: PASS — Debug/Release builds, Integration Tests, NativeAOT transport/topology smoke, package contract verification/smoke, demo/load smoke, and the complete six-platform desktop codec compatibility matrix.The first Windows ARM codec producer attempt hit a hosted-runner
.NET setupCLR internal error (0x80131506) before project execution. The failed jobs were rerun on the identical PR merge ref; Windows ARM production/verification and the final codec/Extended summaries then passed.