Fix useEffectEvent render-phase violation from synchronous emit()#11
Merged
Conversation
…lations Both emit() calls for the 'refetching' event fired synchronously during React's render phase, triggering useEffectEvent errors. Wrapping in queueMicrotask() defers them to after render completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit()calls for therefetchingevent usingqueueMicrotask()subscribe()emitted synchronously when a pending resolver existed, triggering React'suseEffectEventrender-phase guardquery()emitted synchronously after adding the resolver to cache, causing the same violationNotes
All 61 existing tests pass. No behavioral change — events still fire in the same microtask tick, just not synchronously during the calling render frame.