Test and document truncated p-values#18
Open
ewallace wants to merge 2 commits intoStoreyLab:masterfrom
Open
Conversation
This describes the problem with truncated p-values causing an error in qvalue, as raised repeatedly in StoreyLab#9 and https://support.bioconductor.org/p/105623/ Hopefully, describing the problem in the help file will make it easier for users to diagnose and fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempted fix of the error where if truncated p-value distributions are input with default parameters, qvalue fails with
Error in smooth.spline(lambda, pi0, df = smooth.df).This error has been raised repeatedlt, in #9, #17 and https://support.bioconductor.org/p/105623/
And I just had the same problem.
I made 2 changes to qvalue:
pnow describes this problem and how to fix itmax(p) < 0.5andpi0 = NULLThe goal is that users will encounter the error in the doucmentation and fix it quickly without needing to google.