Skip to content

Config schema generator: Backport latest changes from Aspire#1418

Merged
bart-vmware merged 1 commit into
mainfrom
update-config-schema-gen
Dec 20, 2024
Merged

Config schema generator: Backport latest changes from Aspire#1418
bart-vmware merged 1 commit into
mainfrom
update-config-schema-gen

Conversation

@bart-vmware

Copy link
Copy Markdown
Member

Description

This PR backports the latest changes from the Aspire Configuration Schema Generator.
Based on microsoft/aspire#6312. Targets System.Text.Json v9, which contains breaking changes.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@sonarqubecloud

Copy link
Copy Markdown

@bart-vmware bart-vmware marked this pull request as ready for review December 20, 2024 10:44
@bart-vmware bart-vmware requested a review from TimHess December 20, 2024 10:45

@TimHess TimHess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware merged commit 83d95dc into main Dec 20, 2024
@bart-vmware bart-vmware deleted the update-config-schema-gen branch December 20, 2024 12:25
@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants