Skip to content

Enhance: Change accordion icon plus to cross while accordion panel is open#122

Merged
Arifulislam5577 merged 5 commits into
StaticMania:mainfrom
ridoystarlord:enhance/accordion-icon-rotation
Dec 31, 2023
Merged

Enhance: Change accordion icon plus to cross while accordion panel is open#122
Arifulislam5577 merged 5 commits into
StaticMania:mainfrom
ridoystarlord:enhance/accordion-icon-rotation

Conversation

@ridoystarlord
Copy link
Copy Markdown
Contributor

What does this PR do?

This is an enhancement in the accordion component icon. Previously, If anyone open the accordion then the plus icon remaining same but now it will gonna be cross icon which is more user friendly.
Fixed #120

Type of change

  • Accordion Icon styles changes
    Screenshots:
    Before:
    image
    After:
    image

Video: watch Video

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 1:30pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 31, 2023

@ridoystarlord is attempting to deploy a commit to the StaticMania Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread app/src/components/Accordion/theme.ts Outdated
@Arifulislam5577
Copy link
Copy Markdown
Collaborator

Hi Dear @ridoystarlord,

Thank you for your valuable contribution. Please consider using 'rotate-[225deg]' instead of 'rotate-45' for a similar effect with a slightly different view. Also, provide a proper commit message with a minimum of 14 characters. Ensure that the commit message starts with an uppercase letter and ends with a period, Like dot(.).

Regards,
Md Ariful Islam

Comment thread app/src/components/Accordion/theme.ts Outdated
@Arifulislam5577
Copy link
Copy Markdown
Collaborator

Hi Dear @ridoystarlord,

Thank you for your valuable contribution. Please consider using 'rotate-[225deg]' instead of 'rotate-45' for a similar effect with a slightly different view. Also, provide a proper commit message with a minimum of 14 characters. Ensure that the commit message starts with an uppercase letter and ends with a period, Like dot(.).

Regards, Md Ariful Islam

@ridoystarlord Please read the last two line from this reply message and add a proper commit message.

@ridoystarlord
Copy link
Copy Markdown
Contributor Author

Could You please check now. I pushed again.

@Arifulislam5577
Copy link
Copy Markdown
Collaborator

Hi @ridoystarlord,

Thank you for your contribution! We appreciate your effort in enhancing the user experience by adding the accordion icon change when the accordion panel is open. This is a valuable improvement, and it aligns well with our goal of creating a more user-friendly interface.

Your commitment to enhancing the project is commendable. If you have any further suggestions or if there's anything else you'd like to contribute, please feel free to let us know. We value your input and look forward to more collaborations in the future.

Best regards,
Md Ariful Islam

@Arifulislam5577
Copy link
Copy Markdown
Collaborator

Could You please check now. I pushed again.

Hi @ridoystarlord,

Thank you for your contribution! We appreciate your effort in enhancing the user experience by adding the accordion icon change when the accordion panel is open. This is a valuable improvement, and it aligns well with our goal of creating a more user-friendly interface.

Your commitment to enhancing the project is commendable. If you have any further suggestions or if there's anything else you'd like to contribute, please feel free to let us know. We value your input and look forward to more collaborations in the future.

Best regards,
Md Ariful Islam

@ridoystarlord
Copy link
Copy Markdown
Contributor Author

ridoystarlord commented Dec 31, 2023

Thanks for merge. @Arifulislam5577. can you please add me as a https://prnt.sc/5xFDEc8uWjY8 in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion Icon does not turn to cross on open

2 participants