Repository navigation
fix(summary): report stale only when missed ping monitoring is enabled - #982
Merged
Merged
Conversation
The collector runs daily by default while the missed ping timeout defaults to 60 minutes, so /api/summary marked every device stale for most of each day (observed on the 2.0.0-beta.1 deployment: 15 of 15 reporting devices stale 12 hours after the daily run). Report stale only when metrics.notify_on_missed_ping is enabled, since that is when the operator has set a timeout to match the collector schedule. last_seen is still always reported.
Starosdev
pushed a commit
that referenced
this pull request
Oct 15, 2026
## [2.0.0-beta.2](v2.0.0-beta.1...v2.0.0-beta.2) (2026-10-15) ### Bug Fixes * **ci:** publish distinct per-image tags for prerelease versions ([35b8637](35b8637)) * **docker:** strip Debian's zfsutils-linux cron + scripts from the remaining images ([2ba3df5](2ba3df5)) * **docker:** strip Debian's zfsutils-linux cron + scripts from the remaining images ([c11e245](c11e245)) * **docker:** strip Debian's zfsutils-linux cron from the omnibus image ([b9d5130](b9d5130)) * **summary:** report stale only when missed ping monitoring is enabled ([#982](#982)) ([0ba95a0](0ba95a0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/summarymarked every device stale for most of each day on a default install. The metrics collector runs daily (0 0 * * *) while the missed ping timeout defaults to 60 minutes. Found on the2.0.0-beta.1deployment on Zeus: 15 of 15 reporting devices werestale: trueabout 12 hours after the daily run.staleis now reported only when missed ping monitoring is enabled;last_seenis always reported.Type of Change
Related Issues
Related to #965. Follows #975.
Changes Made
annotateStaleness(webapp/backend/pkg/web/handler/get_devices_summary.go): setsstaleonly whenmetrics.notify_on_missed_pingis enabled, because that is when the operator has set a timeout that matches the collector schedule.last_seenis set whenever last-seen data exists.docs/openapi.yamlandexample.scrutiny.yamldescribe whenstaleis present.auto_archive_stale_daysand the device timeout.Testing
go build ./...,go vet,go test ./webapp/backend/pkg/web/...pass;golangci-lint run --new-from-rev=origin/beta(v2.14.0, linux/amd64) 0 issues. NewTestGetDevicesSummaryOmitsStaleWhenMissedPingMonitoringDisabled(default 60-minute timeout, device last seen 12 hours ago:last_seenpresent,staleabsent); forcingstaleon makes it fail. Existing stale tests now enable missed ping monitoring.Checklist
Review: required (merging publishes the
:betaimages with no separate deploy step)