Repository navigation
fix(frontend): 2.0 login token guidance, drop report_pdf_path, surface notification URL errors - #974
Merged
Merged
Conversation
…rface notification URL errors
3 of 14 tasks
32 of 40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WP-G0 (required frontend changes for 2.0.0). The UI now matches the 2.0 backend: the login page explains where the auth token comes from, the removed
report_pdf_pathsetting is gone, and rejected notification URLs show the server's error instead of failing silently.Type of Change
Related Issues
Related to #965 and #973.
Changes Made
/opt/scrutiny/config/.auth-tokenand thedocker exec <container> cat /opt/scrutiny/config/.auth-tokencommand for omnibus,SCRUTINY_WEB_AUTH_TOKENfor hub/spoke, and a link todocs/AUTH.md. The error box hasrole="alert"and the token show/hide button has anaria-label. No guard or interceptor change was needed:AuthGuardredirects to/loginwhen auth is enabled, and the 401 interceptor clears the token and routes to/loginwithreturnUrl.report_pdf_pathfromapp.config.ts, the dashboard settings component (field, load, save), and the PDF Save Directory input.report_pdf_enabledis unchanged.error.error, elseerror.errors[0], else a generic message) in arole="alert"live region above the URL table.detail.component.htmlalready rendersattribute.status_reason, which the backend now fills forcritical_warning.Testing
npm ci;npm run lint(0 errors; 3 pre-existing prettier warnings in untouched files);npm run test:icons;npm run test:theme;ng test --watch=false --browsers=ChromeHeadless(TOTAL: 248 SUCCESS);npm run build:prod(bundle generation complete). New specs cover the login guidance and the add/test 400 and fallback error display. No manual browser pass.Checklist
Notes
login.component.htmlwas not prettier-clean onbeta; the pre-commit hook reformatted the whole file, so its diff is larger than the content change.GET /api/settings/notify-urlshas no skipped or unsafe flag, and matchingscript://in the client would duplicate backend rules. Tracked in [2.0.0] Phase 1 review follow-ups and frontend changes #973.Review: not required (UI-only change on the
betaintegration branch; an independent read-only review is being run per release coordination)