[Starosdev]

Summary

The Btrfs filesystem and ZFS pool detail pages never show their usage history charts on InfluxDB OSS. GetBtrfsMetricsHistory and GetZFSPoolMetricsHistory used Flux query parameters (params.uuid, params.guid), which only InfluxDB Cloud supports. OSS rejects every call with undefined identifier params, the handlers log a warning, and the API returns metrics_history: null.

GetZFSPoolMetricsHistory was fixed in #157 and regressed one day later: merge 98a1b439 resolved a conflict back to the parameterized form. The Btrfs query was added in May with the same construct. Nothing in CI caught either.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Refactoring (no functional changes)
• CI/CD or infrastructure change

Related Issues

Fixes #1111
Related to #155, #157

Changes Made

• scrutiny_repository_btrfs.go, scrutiny_repository_zfs.go: validate the identifier inside the repository function (ValidateUUID / ValidateGUID) and inline it as a strconv.Quote Flux string literal via Query. This is the pattern GetMdadmMetricsHistory and the temperature queries already use. Handler-level validation stays as a second layer.
• .golangci.yml: enable forbidigo with a rule that fails lint on QueryWithParams / QueryRawWithParams, so a future merge-conflict resolution cannot restore the pattern silently. The message points at fix(database): revert parameterized queries for InfluxDB OSS compatibility #157 and [BUG] Btrfs usage history is never shown: parameterized Flux query fails on InfluxDB OSS ("undefined identifier params"), same as #155 #1111.
• scrutiny_repository_metrics_history_test.go: a recording QueryAPI stub asserts the generated query inlines the quoted id and never contains params., and that an invalid id is rejected before any query runs.

Testing

• I have tested this locally
• I have added/updated tests that prove my fix/feature works
• All existing tests pass

Local: go build ./webapp/backend/pkg/database/ and go vet ./webapp/backend/pkg/database/ pass; gofmt -l clean on changed files; pre-commit gofmt and vet hooks pass. The Go test suite and golangci-lint run in CI on this PR; I did not run the full suite locally. No Btrfs or ZFS host was available to verify the chart end to end; the issue reporter's reproduction (metrics_history: null plus the undefined identifier params warning) is the failing path these changes remove.

Review: not required (change ships through the develop-to-master promotion PR and a manual release, no direct production effect on merge)

Follow-up

Even with the query working, both charts are capped at the main bucket's 15-day retention: btrfs_filesystem and zfs_pool are not part of the downsampling tasks, and lookupBucketName routes month and year ranges to _weekly / _monthly buckets that hold no data for them. Not addressed here; an enhancement issue for downsampling the capacity fields and adding a range selector on both detail pages is still to be filed.

beta carries the same two params.* queries (scrutiny_repository_btrfs.go:215, scrutiny_repository_zfs.go:382) and gets this fix through the next master-into-beta sync. The forbidigo rule will flag them there until the sync lands.

Checklist

• My code follows the project's code style
• I have performed a self-review of my code
• I have commented my code where necessary (particularly complex areas)
• I have updated the documentation if needed
• My changes generate no new warnings