[RyoKusnadi]

Summary

Follow-up to #1085 and #1086, as @Starosdev asked in the approval comment. The report's alert line now takes its ATA value from measurements.AttributeEvaluatedValue, and the extra exported SmartAtaAttribute.ThresholdValue is removed. No change in what the report prints.

Problem: None visible to users. This is a cleanup. Until #1086 landed, the report code had its own copy of "which ATA field does the status use", through an exported method added only for it.

How it happens: Not a bug. It was a stop-gap, noted in a comment in alertAttributeDetails.

Cause: #1085 merged before AttributeEvaluatedValue existed, so it called ThresholdValue, which gives the same result.

Type of Change

• Refactoring (no functional changes)

Related Issues

Follow-up to #1085 and #1086. No issue.

Changes Made

• generator.go: for an ATA attribute with metadata, value comes from AttributeEvaluatedValue. The ATA-without-metadata rule (normalized value, as the detail page shows) stays, as the helper would give the raw value there. Comment updated.
• smart_ata_attribute.go: removed ThresholdValue. Nothing else called it (searched the repo). The private thresholdValue stays.

Scope: The nullable threshold is a separate PR (#1103). It touches nearby lines in alertAttributeDetails, so the second to merge may need a small rebase.

Testing

• I have tested this locally
• I have added/updated tests that prove my fix/feature works

Added TestAlertAttributeDetails_ATAValueMatchesEvaluatedValue: for every ATA attribute with metadata, the alert value equals AttributeEvaluatedValue. As this is a refactor it passes before and after; the existing TestAlertAttributeDetails cases pass unchanged.

Commands: go vet and go test on webapp/backend/pkg/reports and webapp/backend/pkg/models/measurements (pass), gofmt -l on the changed files (clean). go vet also on pkg/notify and pkg/web/.... I did not run the full suite.

[RyoKusnadi]

@Starosdev here is the follow-up you asked for in #1085 (switch to AttributeEvaluatedValue and drop ThresholdValue). Could you please review it when you have a moment? Thank you!

[Starosdev]

Approving at head 526bc954. Source-traced; CI green. AttributeEvaluatedValue resolves AtaMetadata[id].DisplayType exactly as the old ThresholdValue(metadata.DisplayType) call did, so output is unchanged, including the RawValue fallback for 174, 204, 227 and 228. ThresholdValue has no callers left. Two optional nits, no change needed: line 120 of the doc comment is wider than the rest of the block, and a case asserting RawValue for attribute 174 would pin the claim in that comment directly. Merging this first; #1103 will rebase onto it.