Repository navigation
revert(ci): drop the duplicate develop-collector-omnibus build - #1017
Merged
Merged
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1016. Its premise was wrong and it caused an architecture regression on an existing tag.
docker-build.yamlalready triggers on pushes todevelopand publishesdevelop-${{ matrix.image }}for every entry indocker/image-matrix.json, which includescollector-omnibus.develop-collector-omnibustherefore already existed, and multi-arch. The gap #1016 claimed to close was not real.The reason the tag was not found by inspection: the tag name is templated, so grepping the workflows for the literal string
develop-collectormatches nothing.The regression
#1016 added a second, amd64-only build that pushed the same tag. Because #1016 touched only
deploy-testing.ymlanddocs/**, it misseddocker-build.yaml's path filters, so the Docker workflow did not run on that push to restore the multi-arch manifest. Observed on a host after the merge:develop-collector-omnibusafter #1016develop-collectorfromdocker-build.yamlAn arm64 host pulling
develop-collector-omnibuswould no longer find a matching manifest.Type of Change
Related Issues
Reverts #1016. Follow-up to #1011.
Changes Made
develop-collector-omnibusbuild step fromdeploy-testing.yml.docs/DEPLOYMENTS.mdanddocs/TROUBLESHOOTING_DOCKER.md. The original tables were correct; ci(testing): publish a develop-collector-omnibus testing image #1016 replaced them with a narrower list that described onlydeploy-testing.ymland ignored the tagsdocker-build.yamlpublishes on the same push.Testing
I have tested this locally
I have added/updated tests that prove my fix/feature works
All existing tests pass
deploy-testing.ymlparses as YAML and is byte-identical to its state before ci(testing): publish a develop-collector-omnibus testing image #1016.Verified from the workflow definitions rather than by grepping for tag strings:
docker-build.yamlruns onpushtodevelop, and itsdocker/metadata-actionconfig emitsdevelop-${{ matrix.image }}for each of the 8 matrix entries.The multi-arch manifest for
develop-collector-omnibusneeds one run ofdocker-build.yamlto be restored, since this revert only stops the overwriting. Being dispatched separately againstdevelop.Checklist
Additional Notes
Review: not required (removes a build step added hours earlier and restores two documentation tables to their prior content).
One pre-existing documentation gap is left alone here to keep this a clean revert: all three channel rows omit
*-collector-omnibus, whichdocker/image-matrix.jsondoes build for stable, beta and develop alike. That deserves its own change rather than riding along with a revert.