Skip to content

revert(ci): drop the duplicate develop-collector-omnibus build - #1017

Merged
Starosdev merged 1 commit into
developfrom
revert/develop-collector-omnibus-publish
Oct 20, 2026
Merged

Starosdev merged 1 commit into
developfrom
revert/develop-collector-omnibus-publish

Conversation

@Starosdev

Copy link
Copy Markdown
Owner

Summary

Reverts #1016. Its premise was wrong and it caused an architecture regression on an existing tag.

docker-build.yaml already triggers on pushes to develop and publishes develop-${{ matrix.image }} for every entry in docker/image-matrix.json, which includes collector-omnibus. develop-collector-omnibus therefore already existed, and multi-arch. The gap #1016 claimed to close was not real.

The reason the tag was not found by inspection: the tag name is templated, so grepping the workflows for the literal string develop-collector matches nothing.

The regression

#1016 added a second, amd64-only build that pushed the same tag. Because #1016 touched only deploy-testing.yml and docs/**, it missed docker-build.yaml's path filters, so the Docker workflow did not run on that push to restore the multi-arch manifest. Observed on a host after the merge:

Tag Architectures
develop-collector-omnibus after #1016 amd64
develop-collector from docker-build.yaml amd64, arm, arm64

An arm64 host pulling develop-collector-omnibus would no longer find a matching manifest.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or infrastructure change

Related Issues

Reverts #1016. Follow-up to #1011.

Changes Made

  • Removes the duplicate develop-collector-omnibus build step from deploy-testing.yml.
  • Restores the published tag tables in docs/DEPLOYMENTS.md and docs/TROUBLESHOOTING_DOCKER.md. The original tables were correct; ci(testing): publish a develop-collector-omnibus testing image #1016 replaced them with a narrower list that described only deploy-testing.yml and ignored the tags docker-build.yaml publishes on the same push.

Testing

  • I have tested this locally

  • I have added/updated tests that prove my fix/feature works

  • All existing tests pass

  • deploy-testing.yml parses as YAML and is byte-identical to its state before ci(testing): publish a develop-collector-omnibus testing image #1016.

  • Verified from the workflow definitions rather than by grepping for tag strings: docker-build.yaml runs on push to develop, and its docker/metadata-action config emits develop-${{ matrix.image }} for each of the 8 matrix entries.

  • The multi-arch manifest for develop-collector-omnibus needs one run of docker-build.yaml to be restored, since this revert only stops the overwriting. Being dispatched separately against develop.

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code where necessary (particularly complex areas)
  • I have updated the documentation if needed
  • My changes generate no new warnings
  • No console.log, debug statements, or commented-out code

Additional Notes

Review: not required (removes a build step added hours earlier and restores two documentation tables to their prior content).

One pre-existing documentation gap is left alone here to keep this a clean revert: all three channel rows omit *-collector-omnibus, which docker/image-matrix.json does build for stable, beta and develop alike. That deserves its own change rather than riding along with a revert.

@Starosdev
Starosdev merged commit d21f7fc into develop Oct 20, 2026
40 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant