Packaging: Improve rpm scriptlet / deb maintainer script docs #6315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lines were in st2.spec. They will need to be expanded in a follow-up commit.
Document all scripts, and update deb docs to better describe when various args might be used and add some missing variants.
cognifloyd
requested review from
a team,
amanda11,
guzzijones,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/L
nzlosh
approved these changes
Mar 14, 2025
guzzijones
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.
I recommend reviewing each commit of this PR.
The first commit 41a7797 adds a few scripts that were not separate files in st2-packages.git, so they didn't get cherry-picked in:
The second commit 15bbd13 copies code from this section of the rpm st2.spec in st2-packages.git:
The third commit 4ca7ec9 adds docs for all of the rpm scriptlets and deb maintainer scripts to help during refactoring.