Pants: Minor test refactor to support running under pants+pytest #6253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
a team,
amanda11,
guzzijones,
mamercad and
nzlosh
pull-request-size
bot
added
the
size/M
nzlosh
approved these changes
Sep 26, 2024
amanda11
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a couple of commits extracted from #6202 where I'm working on getting all of our unit tests to run under pants+pytest.
1 test relied on
tests_config.parse_args()happening when nose imported or ran earlier tests (similar to changes in #6241).For the other test, pants does not copy BUILD files into the sandbox, so we need to completely ignore the BUILD files when they exist (ie when running nosetest or pytest directly instead of letting pants run it in a sandbox).
Plus there are a few file dep changes in BUILD metadata to support these.