Skip to content

chore(popover): replace close icon #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dancormier merged 3 commits into from
Nov 21, 2025
Merged

chore(popover): replace close icon #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17e4ded
chore(popover): replace close icon
dancormier Nov 20, 2025
39abb12
Use cross, not cross16
dancormier Nov 20, 2025
8b3f125
Changeset
dancormier Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/silly-spiders-swim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@stackoverflow/stacks": patch
"@stackoverflow/stacks-svelte": patch
---

Change popover close icon to Cross
2 changes: 1 addition & 1 deletion packages/stacks-classic/lib/components/popover/popover.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
float: right; // Use floats for title wrapping
top: calc(var(--su8) * -1); // Compensate for s-popover's padding
right: calc(var(--su8) * -1); // Compensate for s-popover's padding
padding: var(--su8) !important;
padding: var(--su6) !important;
}

& &--content {
Expand Down
4 changes: 2 additions & 2 deletions packages/stacks-docs/product/components/popovers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
<div id="popover-example" class="s-popover is-visible" role="menu">
<button class="s-popover--close s-btn s-btn__muted" aria-label="Close"
data-action="s-popover#toggle">
@Svg.ClearSm
@Svg.Cross
</button>
<div class="s-popover--content">
…
Expand All @@ -293,7 +293,7 @@
{% endhighlight %}
<div class="stacks-preview--example bg-black-100">
<div class="s-popover ps-relative is-visible">
<button class="s-popover--close s-btn s-btn__muted" aria-label="Close">{% icon "ClearSm" %}</button>
<button class="s-popover--close s-btn s-btn__muted" aria-label="Close">{% icon "Cross" %}</button>
<div class="s-popover--content">
<p class="mb0">Dismissible persistent popover presented with a close button</p>
</div>
Expand Down
4 changes: 2 additions & 2 deletions packages/stacks-svelte/src/components/Popover/PopoverCloseButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import Icon from "../Icon/Icon.svelte";
import { IconClear } from "@stackoverflow/stacks-icons-legacy/icons";
import { IconCross } from "@stackoverflow/stacks-icons/icons";
import { usePopoverContext } from "./Popover.svelte";

interface Props {
Expand Down Expand Up @@ -34,5 +34,5 @@
type="button"
onclick={handleClick}
>
<Icon src={IconClear} />
<Icon src={IconCross} />
</button>