feat(tags): Update designs for project SHINE#2038
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 47dbff8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mukunku
changed the title
xs and md sizes removedxs and md sizes removed for project SHINE
ttaylor-stack
requested changes
Nov 6, 2025
Collaborator
There was a problem hiding this comment.
Good work, there's a few issues with some of the component styles that need addressing. I've added @CGuindon to the PR too to confirm.
Also you need to add a changeset (see comment by the changeset-bot)
mukunku
changed the title
xs and md sizes removed for project SHINE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is for SPARK-80 and adjusts the Tags component according to the latest Figma designs.
Noteworthy Items
disabledstate mentioned in the designs have been deemed unneeded as "disabled" tags only happen in post-summary and that component already controls how it formats disabled tags itself.black-400toblack-500in high-contrast mode as it was failing the AAA wcag contrast test:Breaking Changes
This PR:
.s-tag__xsand.s-tag__mdsizes.s-tag__smto match the now removed.s-tag__xsin sizeHow to Test
There are two places to confirm the changes: