Repository navigation
Conversation
Clicking a task key in an agent's reply navigated to Tasks, so checking one task meant finding your way back to the thread. A plain click now opens the task in the chat's existing task sheet; clicking outside it or its close button returns to the thread. Cmd/Ctrl/Shift and middle clicks still go through the router, the href still names the task, and the sheet gains an Open in Tasks action for the full view. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbe6a8599e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| topFadeEnabled={!hasTimelineTopBanner} | ||
| /> | ||
| <IssueMentionOpenContext | ||
| value={props.onOpenIssueContext === undefined ? setLocalIssueDetailKey : null} |
There was a problem hiding this comment.
When ChatView is embedded in IssuesAssistantPanel, that caller supplies onOpenIssueContext specifically to open a task as another panel tab, but this branch gives mention links a null opener. A plain click therefore follows /issues and navigates away from the active conversation instead of opening the task in place. Pass an opener that forwards the mentioned task to the supplied callback, or otherwise preserve the embedded panel flow.
AGENTS.md reference: AGENTS.md:L69-L74
Useful? React with 👍 / 👎.
| openInPlace === null | ||
| ? undefined | ||
| : (event) => { | ||
| if (event.button !== 0 || event.metaKey || event.ctrlKey || event.shiftKey) return; |
There was a problem hiding this comment.
When a user Alt-clicks a task mention, this handler treats it as a plain click, prevents the link's native behavior, and opens the sheet. Alt is a link modifier—commonly used to download the target—and the existing markdown fragment handler in ChatMarkdown.tsx already preserves it alongside Meta/Ctrl/Shift. Include event.altKey in this guard so task links retain the same modified-click behavior as other chat links.
Useful? React with 👍 / 👎.
github-actions
Bot
added
size:M
vouch:trusted
This branch has not been deployed
1 participant
Clicking a task key such as
COR-159in an agent's reply navigated to Tasks, so checking one task meant finding your way back to the thread afterwards.IssueMentionOpenContextwraps only the message timeline. Links rendered anywhere else keep navigating as before, including the Tasks assistant panel, which already sits on Tasks.Surfaces: web and desktop share the chat view. Mobile doesn't linkify task keys, so nothing changes there. The user docs on tasks are updated.
Tests: a plain click opens the task in place; Cmd-clicks and middle-clicks don't; existing link tests are rendered through React now that the link reads context. The web typecheck and lint are clean. Before/after images are still to come: this hasn't been tried in a real client yet.
Model: Claude Opus 5.5. Harness: Claude Code.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.