chore: update specterops nuget source to shcommon-nuget BED-8241

[lrfalslev]

Description

Old bloodhound-ad s3 bucket has been replaced with new shcommon-nuget bucket for the specterops nuget feed. This updates sleet config and github workflows to use new the new feed.

Motivation and Context

This PR addresses: BED-8241

How Has This Been Tested?

Ran sleet validate and tested publishing and pruning -dev packages to feed.

Screenshots (if appropriate):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README BloodHound#672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Chores
  • Updated package publishing workflow to point at an alternate NuGet package source.
  • Updated package feed configuration to use the new S3 package bucket.
  • Clarified package cleanup behavior to prune older dev-package versions relative to the most recent releases.

[coderabbitai]

Walkthrough

sleet.json S3 feed source updated to use the shcommon-nuget bucket/path; publish workflow prune step comment clarified and its package index URL changed to read sleet.packageindex.json from shcommon-nuget.

Changes

S3 Feed & Workflow Update

Layer / File(s)	Summary
S3 feed configuration sleet.json	S3 feed source path and bucketName updated to point to shcommon-nuget and sleet.packageindex.json.
Workflow prune step .github/workflows/publish-dev-package.yml	Prune-step inline comment updated; prune script’s $packageIndexUrl changed to read sleet.packageindex.json from the shcommon-nuget bucket instead of bloodhound-ad.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A little hop to the new bucket door,
Index in paw, I fetch and explore.
A comment tuned, a URL sent,
Packages lined up, tidy and bent.
The rabbit hums — migration done, encore.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: updating the NuGet source configuration from bloodhound-ad to shcommon-nuget, which is reflected in both modified files.
Description check	✅ Passed	The pull request description includes all required template sections with sufficient detail about the changes and testing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lfalslev/bed-8241

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/publish-dev-package.yml:
- Around line 6-7: Restore the "v4" push trigger in the workflow's push branch
list so the job runs on pushes to the release branch; update the array that
currently contains "lfalslev/bed-8241" (and has "v4" commented out) to include
"v4" again alongside any feature branches, ensuring the workflow will run for
normal v4 pushes after merge.
- Line 59: The workflow hardcodes $dryRun = $true which prevents prune from ever
running; change this to read a workflow input or environment variable (e.g.,
inputs.prune_dry_run or PRUNE_DRY_RUN) and default to false so pruning runs by
default, then set $dryRun = ${{ github.event.inputs.prune_dry_run ||
env.PRUNE_DRY_RUN }} (or equivalent expression) and update the workflow
inputs/env to document the flag so debugging can explicitly enable dry-run mode;
ensure any action/step that uses $dryRun (the variable named $dryRun) respects
the parsed boolean value.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22e08e58-91a0-4510-aca9-728e89d3e435

📥 Commits

Reviewing files that changed from the base of the PR and between 2851273 and bdc1d25.

📒 Files selected for processing (2)

• .github/workflows/publish-dev-package.yml
• sleet.json