Fix IE11 "SCRIPT16389: Unspecified error." when dragging element#1865
Closed
laukstein wants to merge 7 commits intoSortableJS:masterfrom
Closed
Fix IE11 "SCRIPT16389: Unspecified error." when dragging element#1865laukstein wants to merge 7 commits intoSortableJS:masterfrom
laukstein wants to merge 7 commits intoSortableJS:masterfrom
Conversation
Contributor
|
If you can resolve the conflicts, I'll merge this. |
Author
|
@waynevanson I can't resolve the conflict because not having "write access" to SortableJS/Sortable. Give me the permissions and I'll be able to resolve this. |
Contributor
|
@laukstein You don't need permissions. You have to have patch-1 and master branches. Master should be the head of Sortable. On your machine, checkout to master. Now merge patch-1 into master and resolves the conflicts. That's a pull request should be done. Alternatively, you can create the pull from scratch and you'll have no conflicts. The conflicts exists b3cause there's no util.js because it's been replaced with util.ts |
…ortableJS#1875) * deps: install dev-deps for ts, tests and friends * tests: replace test.js with test.ts and fp * change compat tests * ci: replace tests to use npm as per usual
…1878) The doc was missing the case of keeping the default insertion point based on the direction.
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci
* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci * build: bundles with rollup ^2.14 and typescript * dist: create new dist files * chore: bump minor version * build(refactor): removes unused babel plugin
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail
IE11 throws error "SCRIPT16389: Unspecified error." when dragging element after `Sortable.create(...)` was executed more than 1 time while in same page (without page reload). This issue happens also in Sortable earlier versions, and due to this error may stop Sortable functionality at all. Using `el.parentNode` for simplest fix checking if element sort of exists in DOM (by checking if parent element exists). Universal fix would be to use `document.body.contains(el)`, but I think it is too much here and would cause small performance impact, that's way fixing it is simple way.
Author
|
@waynevanson I created a new PR for it #1904 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE11 throws error "SCRIPT16389: Unspecified error." when dragging element after
Sortable.create(...)was executed more than 1 time while in same page (without page reload).This issue happens also in Sortable earlier versions, and due to this error may stop Sortable functionality at all.
Using
el.parentNodefor simplest fix checking if element sort of exists in DOM (by checking if parent element exists). Universal fix would be to usedocument.body.contains(el), but I think it is too much here and would cause small performance impact, that's way fixing it is simple way.