only loop through own properties inside for..in#1544
Closed
OkanEsen wants to merge 1 commit intoSortableJS:masterfrom
Closed
only loop through own properties inside for..in#1544OkanEsen wants to merge 1 commit intoSortableJS:masterfrom
OkanEsen wants to merge 1 commit intoSortableJS:masterfrom
Conversation
|
Totally agréé. This is very close to my own PR #1540. At least we have the choice for the fix 😉 |
Author
|
Oh I'm sorry, because of the title, I didn't bother to check for pull requests which might fix the same issue. 😄 I'm going to close this one, thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the
for..inloops are running through all properties. I think it would be wise to check for the own properties, because other libraries could mess with the native types, like the one I'm facing right now.