Upgrades to 0.9.30 by claravanstaden · Pull Request #710 · Snowfork/snowbridge

claravanstaden · 2022-10-27T14:20:52Z

…ntime-benchmarks

claravanstaden · 2022-11-07T17:57:58Z

E2E pass on Snowbridge:

  Bridge
2022-11-07 13:32:58        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    Basic Channel
      ✓ should transfer DOT for 6 accounts from Substrate to Ethereum (basic channel) (122963ms)

  Bridge
2022-11-07 13:35:02        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    Bootstrap
      ✓ should transfer DOT from Substrate to Ethereum (basic channel) (131186ms)
      ✓ should transfer ETH from Ethereum to Substrate (basic channel) (227017ms)

  Bridge
2022-11-07 13:41:01        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    DOT App
      ✓ should transfer DOT from Substrate to Ethereum (incentivized channel) (126176ms)
      ✓ should transfer DOT from Ethereum to Substrate (basic channel) (233271ms)
      ✓ should transfer DOT from Ethereum to Substrate (incentivized channel) (191806ms)

  Bridge
2022-11-07 13:50:13        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    ERC20 App
      ✓ should transfer ERC20 tokens from Ethereum to Substrate (267989ms)
      ✓ should transfer ERC20 from Substrate to Ethereum (146013ms)
    ERC20 App XCM
      ✓ should transfer ERC20 tokens from Ethereum to Parachain 1001 (249981ms)
      ✓ should not transfer ERC20 tokens from Ethereum to Parachain 1001 without fee (287997ms)
      ✓ should not transfer ERC20 tokens from Ethereum to non-existent Parachain 2001 (215999ms)

  Bridge
2022-11-07 14:09:48        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    ETH App
      ✓ should transfer ETH from Substrate to Ethereum (incentivized channel) (133200ms)
    ETH App XCM
      ✓ should transfer ETH from Ethereum to Parachain 1001 (incentivized channel) (213968ms)

      ✓ should not transfer ETH from Ethereum to Parachain 1001 without fee (293996ms)
      ✓ should not transfer ETH from Ethereum to non-existent Parachain 2001 (306004ms)

  Bridge
    Malicious DOT App
      - should deliver message but fail to transfer DOT from Substrate to Ethereum (basic channel)
      
  15 passing (53m)
  1 pending

Done in 3159.80s.

…ara/sno333-upgrade-to-v0.9.30

vgeddes

+1

alistair-singh · 2022-11-09T15:01:47Z

@@ -12,26 +12,26 @@ targets = [ "x86_64-unknown-linux-gnu" ]
 [dependencies]
 serde = { version = "1.0.137", optional = true }
 codec = { version = "3.0.0", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }


Should we standardise parity-scale-codec to version 3.1.5 like in the top level Cargo.toml?

Suggested change

codec = { version = "3.0.0", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }

codec = { version = "3.1.5", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }

alistair-singh · 2022-11-09T15:41:08Z

@@ -12,20 +12,20 @@ targets = [ "x86_64-unknown-linux-gnu" ]
 [dependencies]
 serde = { version = "1.0.137", optional = true }
 codec = { version = "3.0.0", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }


Same as above.

doubledup · 2022-11-09T17:22:36Z


-runtime-benchmarks = []
+runtime-benchmarks = [
+	"frame-benchmarking/runtime-benchmarks",


Why do we need the /runtime-benchmarks suffix here? We're using frame-benchmarking in the runtime-benchmarks feature for the runtimes.

doubledup · 2022-11-09T17:34:14Z

+				// https://github.com/paritytech/substrate/blob/1802a115e8480fd7a4654d45c85b58c2189c508a/client/db/src/lib.rs#L1096
+				#[cfg(feature = "runtime-benchmarks")]
+					BenchmarkCmd::Storage(_) => Err(
+						"Storage benchmarking can be enabled with `--features runtime-benchmarks`."


Why do we need to disable storage benchmarking? I can't see the reason at the link above.

Could we change the error message to mention that storage benchmarking is disabled? This will only be displayed when the runtime-benchmarks feature is enabled, but this message advises enabling the same feature.

Suggested change

"Storage benchmarking can be enabled with `--features runtime-benchmarks`."

"Storage benchmarking is disabled."

I missed the not clause here, corrected now. 8fc8037

…Snowfork/snowbridge into clara/sno333-upgrade-to-v0.9.30

Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com>

claravanstaden · 2022-11-10T10:18:23Z

I'm just running the E2E tests again after the latest changes, then I'll merge.

…ara/sno333-upgrade-to-v0.9.30

claravanstaden · 2022-11-10T11:47:24Z

E2E passes after changes:

Bridge
2022-11-10 11:00:32        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    Basic Channel
      ✓ should transfer DOT for 6 accounts from Substrate to Ethereum (basic channel) (133490ms)

  Bridge
2022-11-10 11:02:46        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    Bootstrap
      ✓ should transfer DOT from Substrate to Ethereum (basic channel) (113488ms)
      ✓ should transfer ETH from Ethereum to Substrate (basic channel) (230038ms)

  Bridge
2022-11-10 11:08:30        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    DOT App
      ✓ should transfer DOT from Substrate to Ethereum (incentivized channel) (129464ms)
      ✓ should transfer DOT from Ethereum to Substrate (basic channel) (200027ms)
      ✓ should transfer DOT from Ethereum to Substrate (incentivized channel) (300281ms)

  Bridge
2022-11-10 11:19:00        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    ERC20 App
      ✓ should transfer ERC20 tokens from Ethereum to Substrate (265985ms)
      ✓ should transfer ERC20 from Substrate to Ethereum (136012ms)
    ERC20 App XCM
      - should transfer ERC20 tokens from Ethereum to Parachain 1001
      - should not transfer ERC20 tokens from Ethereum to Parachain 1001 without fee
      - should not transfer ERC20 tokens from Ethereum to non-existent Parachain 2001

  Bridge
2022-11-10 11:25:46        API/INIT: RPC methods not decorated: basicOutboundChannel_getMerkleProof
    ETH App
      ✓ should transfer ETH from Substrate to Ethereum (incentivized channel) (107523ms)
    ETH App XCM
      - should transfer ETH from Ethereum to Parachain 1001 (incentivized channel)
      - should not transfer ETH from Ethereum to Parachain 1001 without fee
      - should not transfer ETH from Ethereum to non-existent Parachain 2001


  9 passing (27m)
  6 pending

claravanstaden added 7 commits October 27, 2022 14:20

Replaces Event, Call and Origin with new names.

4a4aaf9

Updates release branches.

dd23c62

Fix runtimes

9d796f3

Update service.

1f4275d

expose_db and expose_storage functions only available with feature ru…

3807bbe

…ntime-benchmarks

Updates scale info.

6ff86ca

Updates for snowbase

338dcc5

claravanstaden self-assigned this Oct 28, 2022

claravanstaden added 4 commits November 7, 2022 13:11

Updates test parachain. Fixes incorrect logic for benchmarks feature.

d8a336e

Updates toolchain version.

79fff5c

Updates toolchain version.

da8c755

Try version.

0bb1ed2

claravanstaden and others added 6 commits November 8, 2022 12:38

Fixes benchmarking

3d10476

Merge branch 'main' of https://github.com/Snowfork/snowbridge into cl…

6e330be

…ara/sno333-upgrade-to-v0.9.30

Attempts installing protoc

e1b8a1f

Fix benchmarks

28e7207

Fixes warnings.

22a1599

Merge branch 'main' of https://github.com/Snowfork/snowbridge into cl…

ddf7401

…ara/sno333-upgrade-to-v0.9.30

claravanstaden marked this pull request as ready for review November 9, 2022 14:15

claravanstaden requested review from a team, alistair-singh, doubledup and vgeddes November 9, 2022 14:15

vgeddes approved these changes Nov 9, 2022

View reviewed changes

alistair-singh approved these changes Nov 9, 2022

View reviewed changes

doubledup approved these changes Nov 9, 2022

View reviewed changes

doubledup reviewed Nov 9, 2022

View reviewed changes

Comment thread parachain/pallets/basic-channel/src/inbound/test.rs Outdated

claravanstaden added 2 commits November 10, 2022 07:51

PR comments and fix tests.

9dbd518

Merge branch 'clara/sno333-upgrade-to-v0.9.30' of https://github.com/…

1e69d66

…Snowfork/snowbridge into clara/sno333-upgrade-to-v0.9.30

alistair-singh approved these changes Nov 10, 2022

View reviewed changes

doubledup reviewed Nov 10, 2022

View reviewed changes

Comment thread parachain/pallets/incentivized-channel/src/inbound/test.rs Outdated

doubledup approved these changes Nov 10, 2022

View reviewed changes

claravanstaden and others added 2 commits November 10, 2022 09:24

Fix benchmarking check logic.

8fc8037

Update parachain/pallets/incentivized-channel/src/inbound/test.rs

64c04f6

Co-authored-by: David Dunn <26876072+doubledup@users.noreply.github.com>

Merge branch 'main' of https://github.com/Snowfork/snowbridge into cl…

bc534ad

…ara/sno333-upgrade-to-v0.9.30

claravanstaden merged commit ff2b986 into main Nov 10, 2022

claravanstaden deleted the clara/sno333-upgrade-to-v0.9.30 branch November 10, 2022 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades to 0.9.30#710

Upgrades to 0.9.30#710
claravanstaden merged 22 commits into
mainfrom
clara/sno333-upgrade-to-v0.9.30

claravanstaden commented Oct 27, 2022 •

edited

Loading

Uh oh!

claravanstaden commented Nov 7, 2022

Uh oh!

vgeddes left a comment

Uh oh!

alistair-singh Nov 9, 2022

Uh oh!

alistair-singh Nov 9, 2022

Uh oh!

Uh oh!

doubledup Nov 9, 2022

Uh oh!

Uh oh!

Uh oh!

doubledup Nov 9, 2022

Uh oh!

claravanstaden Nov 10, 2022

Uh oh!

Uh oh!

Uh oh!

claravanstaden commented Nov 10, 2022

Uh oh!

claravanstaden commented Nov 10, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	codec = { version = "3.0.0", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }
	codec = { version = "3.1.5", package = "parity-scale-codec", default-features = false, features = [ "derive" ] }

	"Storage benchmarking can be enabled with `--features runtime-benchmarks`."
	"Storage benchmarking is disabled."

Conversation

claravanstaden commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claravanstaden commented Nov 7, 2022

Uh oh!

vgeddes left a comment

Choose a reason for hiding this comment

Uh oh!

alistair-singh Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

alistair-singh Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doubledup Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

doubledup Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

claravanstaden Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

claravanstaden commented Nov 10, 2022

Uh oh!

claravanstaden commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

claravanstaden commented Oct 27, 2022 •

edited

Loading

claravanstaden commented Nov 10, 2022 •

edited

Loading