Repository navigation
Authorize snowdeploy actions per token: converge-only tokens cannot deploy or rollback - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorize snowdeploy actions per token: converge-only tokens cannot deploy or rollback
A token hash line may end in a
scope=<action>[,<action>]field; a scoped token gets 403 on any route outside its actions, an unscoped token is unchanged. Labels containing spaces keep working. The token file fails closed: a scope-like trailing field that is not exactly the grammar, or an unknown action name, is a configuration error at load, so a mistyped scope can never widen a token. README documents the format.Motivation: the SnowSys agent-farm design (D040) grants the farm a converge-only bearer on
deploy.; D035 requires the application, not the proxy, to authorize the action.After merge (operator): release
v0.1.9; SnowSys installs it through a newsnowdeploy-phase11-5-v12bundle and revision20261146(plan Task A11).Verification: gofmt, go vet,
go test ./...(new scope, label and fail-closed tests, proven red first), golangci-lint,go build; per-task Opus review, Fable whole-branch review, one fix wave.