Add Kavita 0.9.x+ compatibility fixes#309
Open
MohamedMaged9258 wants to merge 5 commits into
Open
Conversation
API changes:
- Handle 404 NotFound (in addition to 204 NoContent) for getVolume and getChapter
endpoints, which now return 404 instead of 204 when a resource is not found
- Include libraryId in api/series/scan request body to match the new RefreshSeriesDto
contract that requires both seriesId and libraryId
- Handle 404 NotFound (in addition to 204 NoContent) for getVolume and getChapter
endpoints, which now return 404 instead of 204 when a resource is not found
- Include libraryId in api/series/scan request body to match the new RefreshSeriesDto
contract that requires both seriesId and libraryId
- Replace removed api/upload/reset-chapter-lock endpoint with api/upload/chapter
using an empty URL and lockCover=false to reset chapter cover locks
Browser extension:
- Fix Kavita detection in AppState to match the new title format "Page (Kavita)"
in addition to the standalone "Kavita" title used on the home page
- Fix navbar button not remounting after reader mode; the Angular @if directive
removes and re-adds the <nav> element itself, which getElementsByTagName cannot
match against the element it is called on
- Skip remount when the button is already present to prevent duplicate insertions
- Replace fragile children[4] index with ul.navbar-nav querySelector for a stable
insertion point regardless of sidenav toggle visibility
Tested on Kavita 0.9.0 and 0.9.0.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changes:
endpoints, which now return 404 instead of 204 when a resource is not found
contract that requires both seriesId and libraryId
endpoints, which now return 404 instead of 204 when a resource is not found
contract that requires both seriesId and libraryId
using an empty URL and lockCover=false to reset chapter cover locks
Browser extension:
in addition to the standalone "Kavita" title used on the home page
removes and re-adds the element itself, which getElementsByTagName cannot
match against the element it is called on
insertion point regardless of sidenav toggle visibility